Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2021-01-08 Thread Marco Pivetta
Hey Máté, On Fri, Jan 8, 2021 at 1:20 PM Máté Kocsis wrote: > In the meanwhile I also realized that there are just too many unknowns > currently with this extension, so I cancelled my initial plans of adding > ext/simdjson as a core extension. > Since the majority of issues revolve around uncer

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2021-01-08 Thread Máté Kocsis
Hi Jakub and Nikita, Thank you very much for your elaborate answers, you made good points. In the meanwhile I also realized that there are just too many unknowns currently with this extension, so I cancelled my initial plans of adding ext/simdjson as a core extension. I also agree that using the

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2021-01-05 Thread Nikita Popov
On Tue, Dec 29, 2020 at 5:58 PM Máté Kocsis wrote: > Hi Internals, > > I think this will be my last proposal for quite some while :) > But this time, I'd like to propose bundling the > https://github.com/crazyxman/simdjson_php extension > with some major modifications. > > The proposed OO API is

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2021-01-03 Thread Jakub Zelenka
Hi, On Thu, Dec 31, 2020 at 1:30 AM Máté Kocsis wrote: > Hi Remi and Jakub, > >> > I agree it's too early as the library is young and won't be available in >>> many distros. The PECL path is better in this case IMO as it will allow >>> some time . >> >> > In my opinion, this is a case where maki

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2020-12-31 Thread Máté Kocsis
Sorry, I need to add a small correction for my previous email: JsonParser::getKeyValue() wouldn't allow parsing a truncated JSON document. The on-demand parsing API I mentioned in my opening message is what would make such use-case possible. Besides, I accept if you feel it's too early for a new

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2020-12-30 Thread Máté Kocsis
Hi Remi and Jakub, > I agree it's too early as the library is young and won't be available in >> many distros. The PECL path is better in this case IMO as it will allow >> some time . > > In my opinion, this is a case where making an exception is worth considering. Should the simdjson library be

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2020-12-30 Thread Jakub Zelenka
On Wed, Dec 30, 2020 at 6:52 AM Remi Collet wrote: > Le 29/12/2020 à 17:57, Máté Kocsis a écrit : > > Hi Internals, > > > > I think this will be my last proposal for quite some while :) > > But this time, I'd like to propose bundling the > > https://github.com/crazyxman/simdjson_php extension > >

Re: [PHP-DEV] [RFC] Bundling ext/simdjson into core

2020-12-29 Thread Remi Collet
Le 29/12/2020 à 17:57, Máté Kocsis a écrit : Hi Internals, I think this will be my last proposal for quite some while :) But this time, I'd like to propose bundling the https://github.com/crazyxman/simdjson_php extension with some major modifications. The proposed OO API is included in the desc