Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-12-01 Thread Daniil Gentili
Hi all, Heads up, I'll move this RFC (https://wiki.php.net/rfc/jit_config_defaults) to voting status tomorrow! Regards, Daniil Gentili. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-11-18 Thread daniil
16 nov 2023 10:28:16 Dmitry Stogov : >> No problem, I can change the defaults but remove the fatal error if >> jit=non-zero and jit_buffer_size=0, can I still turn it into a warning >> though? >> > > I think we don't need the warning. It's clear that JIT won't work with > "opcache.jit_buffer_siz

Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-11-16 Thread Dmitry Stogov
> No problem, I can change the defaults but remove the fatal error if > jit=non-zero and jit_buffer_size=0, can I still turn it into a warning > though? > I think we don't need the warning. It's clear that JIT won't work with "opcache.jit_buffer_size=0" in php.ini. Thanks. Dmitry.

Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-11-16 Thread Aleksander Machniak
On 16.11.2023 10:21, Daniil Gentili wrote: No problem, I can change the defaults but remove the fatal error if jit=non-zero and jit_buffer_size=0, can I still turn it into a warning though? Whatever you do, please mention it in the Proposal section of the RFC. -- Aleksander Machniak Kolab Gro

Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-11-16 Thread Daniil Gentili
Hi Dmitry, After upgrading to the new PHP version with this patch, all of them won't be able to start PHP. I don't care a lot about the php.ini defaults, but I don't like to give our users a headache. No problem, I can change the defaults but remove the fatal error if jit=non-zero and jit_b

Re: [PHP-DEV] [RFC] [Discussion] Change how JIT is disabled by default

2023-11-16 Thread Dmitry Stogov
Hi Daniil, Currently JIT may be disabled by setting "opcache.jit=disable" or "opcache.jit_buffer_size=0". Many PHP installations have php.ini with the current default settings "opcache.jit=tracing" and "opcache.jit_buffer_size=0". After upgrading to the new PHP version with this patch, all of them