Re: [PHP-DEV] [PATCH] pg_escape_literal/pg_escape_identifier for pgsql

2011-05-24 Thread Hannes Magnusson
On Tue, May 24, 2011 at 06:37, Yasuo Ohgaki wrote: > 2011/5/20 Hannes Magnusson : >> On Fri, May 20, 2011 at 03:24, Yasuo Ohgaki wrote: >>> Hi all >>> >>> Current PostgreSQL has new escape functions for literals and identifiers. >>> Since there is no function for that, I made patch for that. Atta

Re: [PHP-DEV] [PATCH] pg_escape_literal/pg_escape_identifier for pgsql

2011-05-23 Thread Yasuo Ohgaki
2011/5/24 Yasuo Ohgaki : >> Should we really provide fallback if PQescape(Literal|Identifier) >> isn't available? Did you copy the escaping from postgresql directly? > > Wouldn't it nice to have the same escaping capability for 8.x? > It's not possible to copy the code, since it's binded to Postgre

Re: [PHP-DEV] [PATCH] pg_escape_literal/pg_escape_identifier for pgsql

2011-05-23 Thread Yasuo Ohgaki
2011/5/20 Hannes Magnusson : > On Fri, May 20, 2011 at 03:24, Yasuo Ohgaki wrote: >> Hi all >> >> Current PostgreSQL has new escape functions for literals and identifiers. >> Since there is no function for that, I made patch for that. Attached patch is >> for trunk and tested with PostgreSQL 8.4 a

Re: [PHP-DEV] [PATCH] pg_escape_literal/pg_escape_identifier for pgsql

2011-05-20 Thread Hannes Magnusson
On Fri, May 20, 2011 at 03:24, Yasuo Ohgaki wrote: > Hi all > > Current PostgreSQL has new escape functions for literals and identifiers. > Since there is no function for that, I made patch for that. Attached patch is > for trunk and tested with PostgreSQL 8.4 and 9.0. > > This patch would also ap