Re: [PHP-DEV] [PATCH] ext/snmp/snmp.c memleaks

2007-07-05 Thread Gustaf Gunnarsson
Hi, thank you for reviewing my patch. Antony Dovgal wrote: Are you sure this part of the patch is correct? Yes [[ cut away code ]] First you free the pdu and then go to the retry label which uses it and then frees it again on failure. You misunderstund. status = snmp_synch_respo

Re: [PHP-DEV] [PATCH] ext/snmp/snmp.c memleaks

2007-07-04 Thread Antony Dovgal
Are you sure this part of the patch is correct? if (st == SNMP_CMD_GET) { if ((pdu = snmp_fix_pdu(response, SNMP_MSG_GET)) != NULL) { + snmp_free_pdu(res

Re: [PHP-DEV] [PATCH] ext/snmp/snmp.c memleaks

2007-06-21 Thread sean finney
On Wednesday 20 June 2007 10:40:51 Gustaf Gunnarsson wrote: > Hi, > the following patch fixes memory leaks in the snmp module. ftr, i've had memory leaks in snmp reported in debian as well: http://bugs.debian.org/423296 though i'm not familiar enough with the code to comment on the patch