Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
applied :) Thanks again! On Sun, Jul 31, 2011 at 10:05 PM, Solar Designer wrote: > On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote: >> It looks like your original patch did not change anything in crypt.c > > That's correct.  I overlooked the need to modify crypt.c initially. > I only

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote: > It looks like your original patch did not change anything in crypt.c That's correct. I overlooked the need to modify crypt.c initially. I only got to that when adding the extra tests, at which time I also found the incorrect check in

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
On Sun, Jul 31, 2011 at 8:20 PM, Solar Designer wrote: > Pierre, > > Thanks for the prompt response. > > On Sun, Jul 31, 2011 at 12:12:48PM +0200, Pierre Joye wrote: >> On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: >> > http://news.php.net/php.internals/54098 >> > >> > at least the cryp

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
Pierre, Thanks for the prompt response. On Sun, Jul 31, 2011 at 12:12:48PM +0200, Pierre Joye wrote: > On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: > > http://news.php.net/php.internals/54098 > > > > at least the crypt.c bugfix is a must to apply before releasing 5.3.7 > > and 5.4.0.

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
hi, On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: > Hi, > > Please apply the patches from: > > http://news.php.net/php.internals/54098 > > at least the crypt.c bugfix is a must to apply before releasing 5.3.7 > and 5.4.0. The patches are applied already, they are in 5.3.7RC4 and should

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
Hi, Please apply the patches from: http://news.php.net/php.internals/54098 at least the crypt.c bugfix is a must to apply before releasing 5.3.7 and 5.4.0. On Wed, Jul 20, 2011 at 03:37:14AM +0400, Solar Designer wrote: ... > Anyway, attached are patches adding the tests from crypt_blowfish 1.2

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-19 Thread Solar Designer
Hi, On Mon, Jul 18, 2011 at 11:27:32PM +0200, Pierre Joye wrote: > Thanks for the patches, applied to all active branches. Thank you! > About the tests, it would be very good to have them ported as phpt. As > far as I remember I did that back then when I first ported it to php. No, your tests a

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-18 Thread Pierre Joye
hi! Thanks for the patches, applied to all active branches. About the tests, it would be very good to have them ported as phpt. As far as I remember I did that back then when I first ported it to php. Cheers, On Sun, Jul 17, 2011 at 8:26 PM, Solar Designer wrote: > Hi, > > I released crypt_blo

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-18 Thread Pierre Joye
On Mon, Jul 18, 2011 at 1:23 AM, Pierre Joye wrote: >> Yes - need to release PHP versions with this code first. > > I think we should push this patch to 5.3 now as well, so it will be in > 5.3.7, it is important enough. > Got the OK for 5.3, I will apply the patches later today or tomorrow. Or i

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-17 Thread Pierre Joye
hi! Thanks for the patches! Very welcome :) On Mon, Jul 18, 2011 at 12:51 AM, Solar Designer wrote: > Yes, but this is not terribly important.  In practice, "$2a$" is almost > the same as "$2y$".  For passwords that don't contain the '\xff' > character (which is not even valid in UTF-8 sequenc

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-17 Thread Solar Designer
On Sun, Jul 17, 2011 at 04:29:15PM -0600, Joey Smith wrote: > On Sun, Jul 17, 2011 at 10:26:16PM +0400, Solar Designer wrote: > > + * For actual implementation, we set an array index in the variable "bug" > > + * (0 means no bug, 1 means sign extension bug emulation) and a flag in the > > + * varia

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-17 Thread Joey Smith
On Sun, Jul 17, 2011 at 10:26:16PM +0400, Solar Designer wrote: > + * For actual implementation, we set an array index in the variable "bug" > + * (0 means no bug, 1 means sign extension bug emulation) and a flag in the > + * variable "safety" (bit 16 is set when the safety measure is requested). >