Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-23 Thread Marcus Boerger
Hello Arnaud, Wednesday, July 23, 2008, 8:36:53 AM, you wrote: > Hello Marcus, > On Wednesday 23 July 2008 01:16:14 Marcus Boerger wrote: >> Hello Arnaud, >> >> Tuesday, July 22, 2008, 11:23:47 AM, you wrote: >> >> > Hello, >> >> >> > Care to look into the MultipleIterator next? >> >> >> >>

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-22 Thread Arnaud Le Blanc
Hello Marcus, On Wednesday 23 July 2008 01:16:14 Marcus Boerger wrote: > Hello Arnaud, > > Tuesday, July 22, 2008, 11:23:47 AM, you wrote: > > > Hello, > > >> > Care to look into the MultipleIterator next? > >> > > > That's done, for 5_3 [1] and HEAD [2]. > > And a test [3][4] covering mostly

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-22 Thread Marcus Boerger
Hello Arnaud, Tuesday, July 22, 2008, 11:23:47 AM, you wrote: > Hello, >> > Care to look into the MultipleIterator next? >> > That's done, for 5_3 [1] and HEAD [2]. > And a test [3][4] covering mostly all the cases. > [1] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_5_3.patch > [2] http

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-22 Thread Arnaud Le Blanc
Hello, > > Care to look into the MultipleIterator next? > That's done, for 5_3 [1] and HEAD [2]. And a test [3][4] covering mostly all the cases. [1] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_5_3.patch [2] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_HEAD.patch [3] http://arnaud.

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-19 Thread Arnaud Le Blanc
Hello, > Slightly modified and applied. Thanks for the good work. Thanks :) > Care to look into the MultipleIterator next? Ok, I will do that. Etienne, I think I can do that before the 24th. Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: ht

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-19 Thread Etienne Kneuss
Hello On Sat, Jul 19, 2008 at 5:57 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: --snip-- > > Care to look into the MultipleIterator next? > If you do intend to do it, (or if you don't), please let us know so we can prioritize things, and eventually focus on other things, before the 24th. Thanks

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-19 Thread Marcus Boerger
Hello Arnaud, Thursday, July 10, 2008, 2:16:33 PM, you wrote: > Hello, > On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote: >> Hello Arnaud, >> >> if you can provicde the same for HEAD then I'll submit it. And if you're >> fast enough we might even get it into 5.3.0 :-) Johannes, Luka

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-17 Thread Arnaud Le Blanc
Hello, Ok, that's why I said that I didn't know what to do with these conversions. At now I just left the E_NOTICE errors. Regards > Hello Arnaud, > > I will commit it afte I have reviewed and changed it a bit. Right now you > ignore conversoin errors. I'll change this to throw exceptions to

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-17 Thread Marcus Boerger
Hello Arnaud, I will commit it afte I have reviewed and changed it a bit. Right now you ignore conversoin errors. I'll change this to throw exceptions to be inline with other code. However I am in Tel Aviv right now for a company work meeting, so I have little time this week. marcus Wednesday,

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-16 Thread Lukas Kahwe Smith
On 16.07.2008, at 17:47, Arnaud Le Blanc wrote: On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote: Hello Arnaud, if you can provicde the same for HEAD then I'll submit it. And if you're fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how much time does he have?

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-16 Thread Arnaud Le Blanc
On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote: > Hello Arnaud, > > if you can provicde the same for HEAD then I'll submit it. And if you're > fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how > much time does he have? > > marcus > Hi, I would like to add a

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-10 Thread Arnaud Le Blanc
Hello, On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote: > Hello Arnaud, > > if you can provicde the same for HEAD then I'll submit it. And if you're > fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how > much time does he have? > > marcus Ok, I made it [1]. I n

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-09 Thread Marcus Boerger
Hello Arnaud, if you can provicde the same for HEAD then I'll submit it. And if you're fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how much time does he have? marcus Wednesday, July 9, 2008, 4:16:20 PM, you wrote: > On Wed, Jul 9, 2008 at 11:18 AM, Marcus Boerger <[

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-09 Thread Arnaud Le Blanc
On Wed, Jul 9, 2008 at 11:18 AM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > > Looks very good! Many thanks. > > Best regards, > Marcus > > Thanks :) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation

2008-07-09 Thread Marcus Boerger
Hello Arnaud, Tuesday, July 8, 2008, 3:49:36 PM, you wrote: > Hi, > I have seen a "NEEDS DEVELOPER" flag on the TODO for the "Implement > RecursiveTreeIterator in C" task, so I would like to propose my > implementation [1]. > Currently it follows the PHP implementation, except that it does no