RE: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-02 Thread Andi Gutmans
Original Message- > From: Christer Holgersson [mailto:[EMAIL PROTECTED] > Sent: Thursday, December 02, 2004 11:24 > To: Andi Gutmans > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT > > > > Currently apache and lighttpd. Both are feasible to pat

RE: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-02 Thread Dmitry Stogov
Thursday, December 02, 2004 11:24 > To: Andi Gutmans > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT > > > > Currently apache and lighttpd. Both are feasible to patch, > but I looked into adding this functionality to lighttpd, and > that would requir

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-02 Thread Christer Holgersson
Currently apache and lighttpd. Both are feasible to patch, but I looked into adding this functionality to lighttpd, and that would require a more complicated patch than this, so this won ;-) As you said, it is not the end of the world. I am quite happy to patch PHP myself when needed, but thought

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-02 Thread Andi Gutmans
What front-end are you using? Look it's not the end of the world but you're the first person who seems to have wanted this and I don't see dozens of front-ends being patched to support this. I think it's quite esoteric and I don't like seeing more and more patches, even if they don't do anything

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-02 Thread Christer Holgersson
Yes, it could be implemented that way too, but it would require a patch to all the different front-ends you might be using instead of one simple patch to the backend. You might also have a front-end that you do not have the source for, and thus cannot patch. I consider it a worthwhile patch. It

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-01 Thread Andi Gutmans
I must be missing something. Again, why shouldn't this be the job of whatever is running the FastCGI stuff? So what if it's a web frontend? It should be able to kill the mother implementation so that it also kills its children. At 08:27 AM 12/2/2004 +0100, Christer Holgersson wrote: If you are

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-01 Thread Christer Holgersson
If you are running the FastCGI version of PHP it will start up a number (default 8) of "child" PHP interpretors that will wait around indefinitely for work to do, and the "mother" FastCGI process will automatically restart any process that terminates (and automatically restart every child after

Re: [PHP-DEV] [PATCH] PHP_FCGI_TIMEOUT

2004-12-01 Thread Andi Gutmans
I don't see why this patch is needed. It's the FastCGI implementation's job to do the right thing and terminate the processes according to some kind of strategy. The FCGI processes shouldn't self destruct. Andi At 07:11 PM 12/1/2004 +0100, Christer Holgersson wrote: Included is a patch that adds