Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Dmitry Stogov
I will do it before commit. Didn't have time to check Windows version yet. Thanks. Dmitry. Marcus Boerger wrote: Hello Dmitry, Tuesday, June 10, 2008, 1:11:57 PM, you wrote: Index: Zend/zend.h === RCS file: /repository/ZendEngin

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Marcus Boerger
Hello Dmitry, Tuesday, June 10, 2008, 1:11:57 PM, you wrote: > Index: Zend/zend.h > === > RCS file: /repository/ZendEngine2/zend.h,v > retrieving revision 1.293.2.11.2.9.2.20 > diff -u -p -d -r1.293.2.11.2.9.2.20 zend.h > --- Zend/ze

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Sebastian Bergmann
Dmitry Stogov wrote: Exactly. The "fastcall" attribute wasn't supported before. As 3.4 is quite old this should not be a problem. I somehow read 4.3 initially ;-) -- Sebastian Bergmann http://sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Dmitry Stogov
Exactly. The "fastcall" attribute wasn't supported before. Thanks. Dmitry. Sebastian Bergmann wrote: Dmitry Stogov wrote: The proposed patch for PHP improves the executor. ZEND_GCC_VERSION >= 3400 means >= GCC 3.4.0, right? -- PHP Internals - PHP Runtime Development Mailing List To unsub

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Dmitry Stogov
The recursion elimination itself doesn't show any significant speed difference. Thanks. Dmitry. Nuno Lopes wrote: Nuno Lopes wrote: Out of curiosity, what's the slowdown without fastcall? fastcall calling convention assumes passing parameters in registers instead of pushing them on stack.

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Nuno Lopes
Nuno Lopes wrote: Out of curiosity, what's the slowdown without fastcall? fastcall calling convention assumes passing parameters in registers instead of pushing them on stack. yeah, I know. I was asking what's the slowdown that this patch introduces without the fastcall bits. I'm asking thi

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Sebastian Bergmann
Dmitry Stogov wrote: The proposed patch for PHP improves the executor. ZEND_GCC_VERSION >= 3400 means >= GCC 3.4.0, right? -- Sebastian Bergmann http://sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69 -- PHP Internals

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Dmitry Stogov
Nuno Lopes wrote: Out of curiosity, what's the slowdown without fastcall? fastcall calling convention assumes passing parameters in registers instead of pushing them on stack. Thanks. Dmitry. Despite the potential slowdown, I still think this is the way to go. The engine isn't supposed to

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Nuno Lopes
Out of curiosity, what's the slowdown without fastcall? Despite the potential slowdown, I still think this is the way to go. The engine isn't supposed to crash! Nuno - Original Message - From: "Dmitry Stogov" <[EMAIL PROTECTED]> To: "PHP Internals List" Cc: "Andi Gutmans" <[EMAIL PRO