Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams()

2008-11-03 Thread Felipe Pena
Hi Jonah, Em Seg, 2008-11-03 às 14:44 -0500, Jonah H. Harris escreveu: > On Mon, Nov 3, 2008 at 1:54 PM, Scott MacVicar <[EMAIL PROTECTED]> wrote: > > Your patch was stripped, can you attach against with a .txt extension. > > Attached. > Thanks for the patch! Fixed in CVS. (5.2.7+) -- Regard

Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams()

2008-11-03 Thread Jonah H. Harris
On Mon, Nov 3, 2008 at 1:54 PM, Scott MacVicar <[EMAIL PROTECTED]> wrote: > Your patch was stripped, can you attach against with a .txt extension. Attached. -- Jonah H. Harris, Senior DBA myYearbook.com diff -cr php5/ext/pdo/pdo_stmt.c php5-pdofix/ext/pdo/pdo_stmt.c *** php5/ext/pdo/pdo_stmt.c

Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams()

2008-11-03 Thread Lukas Kahwe Smith
On 03.11.2008, at 19:54, Scott MacVicar wrote: Jonah H. Harris wrote: While using PDOStatement::debugDumpParams, I noticed that it results in an endless loop because the hash table is not being traversed. As such, attached is a patch against php5 HEAD which adds zend_hash_move_forward_ex acco

Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams()

2008-11-03 Thread Scott MacVicar
Jonah H. Harris wrote: > While using PDOStatement::debugDumpParams, I noticed that it results > in an endless loop because the hash table is not being traversed. As > such, attached is a patch against php5 HEAD which adds > zend_hash_move_forward_ex accordingly. > > Your patch was stripped, can