Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Steph Fox
It does contain at least one bug fix (see HEAD NEWS) and many obscure bugs that have probably been bogusfied in the past. I'm mouthy tonight. But I should say two things ('cos that's what I do best): 1) Mike's version of output buffering has been sitting in HEAD for a very long time 2) He w

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Lukas Kahwe Smith
On 26.09.2008, at 22:06, Hannes Magnusson wrote: On Fri, Sep 26, 2008 at 21:38, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: and I are a bit worried, that this code did not see that much testing since it was checked in to HEAD quite a while ago. And seeing that the backport is That sen

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Hannes Magnusson
On Fri, Sep 26, 2008 at 22:05, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > if it does fix bugs .. that changes things of course .. but i asked Mike > specifically about this .. and he did not mention this .. so does it fix > bugs or not? It does contain at least one bug fix (see HEAD NEWS) and

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Hannes Magnusson
On Fri, Sep 26, 2008 at 21:38, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > > and I are a bit worried, that this code did not see that much testing since > it was checked in to HEAD quite a while ago. And seeing that the backport is That sentence worries me a bit. Are you advocating developing n

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Lukas Kahwe Smith
On 26.09.2008, at 22:01, Jani Taskinen wrote: Lukas Kahwe Smith wrote: On 26.09.2008, at 12:04, Michael Wallner wrote: Lukas Kahwe Smith wrote: well the question is does it fix some real world bugs? this late in the game i would not want to include these changes if they "just" add features

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Lukas Kahwe Smith
On 26.09.2008, at 21:59, Pierre Joye wrote: On Fri, Sep 26, 2008 at 9:38 PM, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: So unless you can take our worries away in terms of BC issues, I guess we would prefer to leave this patch out of PHP 5.3. I strongly disagree, for two reasons: 1.

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Daniel Brown
On Fri, Sep 26, 2008 at 3:59 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > > I strongly disagree, for two reasons: > > 1. We are going to release an alpha3, that's the perfect time for such change > 2. The OB code is messy right now, Mike's work cleaned it up and makes > it more maintainable. 5.3 is

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Jani Taskinen
Lukas Kahwe Smith wrote: On 26.09.2008, at 12:04, Michael Wallner wrote: Lukas Kahwe Smith wrote: well the question is does it fix some real world bugs? this late in the game i would not want to include these changes if they "just" add features .. Huh? :) The question to me is, why did you

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Pierre Joye
On Fri, Sep 26, 2008 at 9:38 PM, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > So unless you can take our worries away in terms of BC issues, I guess we > would prefer to leave this patch out of PHP 5.3. I strongly disagree, for two reasons: 1. We are going to release an alpha3, that's the perf

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Lukas Kahwe Smith
On 26.09.2008, at 12:04, Michael Wallner wrote: Lukas Kahwe Smith wrote: well the question is does it fix some real world bugs? this late in the game i would not want to include these changes if they "just" add features .. Huh? :) The question to me is, why did you ask me to do it, when y

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-26 Thread Michael Wallner
Lukas Kahwe Smith wrote: > well the question is does it fix some real world bugs? this late in the > game i would not want to include these changes if they "just" add > features .. Huh? :) The question to me is, why did you ask me to do it, when you're not sure what it's about? Not to be anally a

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-25 Thread Pierre Joye
hi, On Thu, Sep 25, 2008 at 3:54 PM, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > > On 18.09.2008, at 21:02, Michael Wallner wrote: > >> In case the original with patches attached doesn't get through: >> >> http://dev.iworks.at/PATCHES/php53-backport_output.txt >> http://dev.iworks.at/PATCHES/pe

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-25 Thread Lukas Kahwe Smith
On 18.09.2008, at 21:02, Michael Wallner wrote: In case the original with patches attached doesn't get through: http://dev.iworks.at/PATCHES/php53-backport_output.txt http://dev.iworks.at/PATCHES/pecl-backport_output.txt well the question is does it fix some real world bugs? this late in

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-24 Thread Pierre Joye
hi, On Thu, Sep 18, 2008 at 9:02 PM, Michael Wallner <[EMAIL PROTECTED]> wrote: > In case the original with patches attached doesn't get through: > > http://dev.iworks.at/PATCHES/php53-backport_output.txt > http://dev.iworks.at/PATCHES/pecl-backport_output.txt > > > Original Message -

Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]

2008-09-24 Thread David Zülke
Am 18.09.2008 um 21:02 schrieb Michael Wallner: In case the original with patches attached doesn't get through: http://dev.iworks.at/PATCHES/php53-backport_output.txt http://dev.iworks.at/PATCHES/pecl-backport_output.txt Isn't there a typo in colorer.cpp: +php_outout_get_contents(ret