Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-17 Thread Ferenc Kovacs
I know, I've just replied with an example to the "Such a performance regression sounds like an appropriate "punishment" to me for deploying bad code ;-)" statement. btw: http://www.tyrael.hu/2011/06/26/performance-of-error-handling-in-php/ http://www.tyrael.hu/2011/10/09/error-suppression-improvem

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-17 Thread Ilia Alshanetsky
Unless you are deleting thousands of files in a tight loop, the overhead involved won't make any difference for your application. In general your application is throwing many errors, even "benign" E_STRICT or E_NOTICE you are already incurring a performance hit. On Mon, Oct 17, 2011 at 3:49 AM, F

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-17 Thread Ferenc Kovacs
On Mon, Oct 17, 2011 at 8:54 AM, Stas Malyshev wrote: > Hi! > > > On 10/16/11 5:54 PM, Sebastian Bergmann wrote: > >> Such a performance regression sounds like an appropriate "punishment" to >> me for deploying bad code ;-) >> > > By bad code you mean not obsessively checking for stuff that is

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-16 Thread Stas Malyshev
Hi! On 10/16/11 5:54 PM, Sebastian Bergmann wrote: Such a performance regression sounds like an appropriate "punishment" to me for deploying bad code ;-) By bad code you mean not obsessively checking for stuff that is of no importance to them as programmers and is only required because

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-16 Thread Sebastian Bergmann
On 10/12/2011 07:59 AM, Stas Malyshev wrote: Note that on 99% of real PHP code, dozens of "errors" may happen due to multitude of notices and E_STRICTs that we have now and we have no means to disable until the very last moment before printing them. Such a performance regression sounds like an

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-13 Thread Stas Malyshev
Hi! do you think this is worth fixing (in 5.4 trunk)? (as zend_signal was introduced, and this fix will cost litte perf). OK, if it doesn't cost performance then I guess it's fine to apply it. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 2

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-13 Thread Xinchen Hui
2011/10/13 Kalle Sommer Nielsen : > Hi > > 2011/10/13 Xinchen Hui : >> Hi: >> If send signal enabled, no system will be called. >> >> Thkans >> > > What about systems without Zend Signal Handling, like Windows? hmm, I have updated the patch, the fix only take affect when ZEND_SIGNALS defined. :)

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-13 Thread Kalle Sommer Nielsen
Hi 2011/10/13 Xinchen Hui : > Hi: > If send signal enabled, no system will be called. > > Thkans > What about systems without Zend Signal Handling, like Windows? -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-12 Thread Xinchen Hui
s,send,zend, Sent from my iPhone 在 2011-10-13,8:16,Xinchen Hui 写道: > Hi: > If send signal enabled, no system will be called. > > Thkans > > Sent from my iPhone > > 在 2011-10-12,22:59,Stas Malyshev 写道: > >> Hi! >> >> On 10/12/11 7:50 AM, Ilia Alshanetsky wrote: >>> Seems like a fine solution, p

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-12 Thread Xinchen Hui
Hi: If send signal enabled, no system will be called. Thkans Sent from my iPhone 在 2011-10-12,22:59,Stas Malyshev 写道: > Hi! > > On 10/12/11 7:50 AM, Ilia Alshanetsky wrote: >> Seems like a fine solution, performance loss would occur only when >> error happens... > > Note that on 99% of real PH

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-12 Thread Stas Malyshev
Hi! On 10/12/11 7:50 AM, Ilia Alshanetsky wrote: Seems like a fine solution, performance loss would occur only when error happens... Note that on 99% of real PHP code, dozens of "errors" may happen due to multitude of notices and E_STRICTs that we have now and we have no means to disable unt

Re: [PHP-DEV] #60038 SIGALRM cause segfault in php_error_cb

2011-10-12 Thread Ilia Alshanetsky
Seems like a fine solution, performance loss would occur only when error happens... On Tue, Oct 11, 2011 at 5:30 AM, Laruence wrote: > Hi: >    I filed a bug about SIGALRM(or SIGPROF) has chance to cause > segfault in php_error_cb. https://bugs.php.net/bug.php?id=60038 > >    do you think this is