RE: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Steph
[EMAIL PROTECTED] > Sent: 13 September 2004 19:37 > To: Wez Furlong > Cc: [EMAIL PROTECTED]; internals > Subject: Re: [PHP-DEV] small and probably dodgy fix > > > On Mon, 13 Sep 2004, Wez Furlong wrote: > > > I meant that, on linux for example, if you manually undefined >

Re: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Derick Rethans
On Mon, 13 Sep 2004, Wez Furlong wrote: > I meant that, on linux for example, if you manually undefined > HAVE_STRCOLL (to simulate not having it), will the build break? > > If so, then we need a real fix :-) It shouldn't that's why I think this is a wrong fix. I copied the #if HAVE_STRCOLL from

RE: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Steph
the hinterlands. > -Original Message- > From: Wez Furlong [mailto:[EMAIL PROTECTED] > Sent: 13 September 2004 16:01 > To: [EMAIL PROTECTED] > Cc: internals > Subject: Re: [PHP-DEV] small and probably dodgy fix > > > I meant that, on linux for example, if you manu

RE: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Steph
Sent: 13 September 2004 16:01 > To: [EMAIL PROTECTED] > Cc: internals > Subject: Re: [PHP-DEV] small and probably dodgy fix > > > I meant that, on linux for example, if you manually undefined > HAVE_STRCOLL (to simulate not having it), will the build break? > > If so, then we

Re: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Wez Furlong
; #include > > +#define HAVE_STRCOLL 1 > + > #include > > #ifndef ZEND_INCLUDE_FULL_WINDOWS_HEADERS > > > > > > -Original Message- > > From: Wez Furlong [mailto:[EMAIL PROTECTED] > > Sent: 13 September 2004 15:54 > > To: [EMAIL PROTECTED

RE: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Steph
clude +#define HAVE_STRCOLL 1 + #include #ifndef ZEND_INCLUDE_FULL_WINDOWS_HEADERS > -Original Message- > From: Wez Furlong [mailto:[EMAIL PROTECTED] > Sent: 13 September 2004 15:54 > To: [EMAIL PROTECTED] > Cc: internals > Subject: Re: [PHP-DEV] small and probably

Re: [PHP-DEV] small and probably dodgy fix

2004-09-13 Thread Wez Furlong
If that fixes it, doesn't that imply that other systems without strcoll will also fail to build now? (are there any that we care about?) --Wez. On Mon, 13 Sep 2004 15:21:14 +0100, Steph <[EMAIL PROTECTED]> wrote: > Hi list, > > HEAD is broken for me following Derick's new sort flag addition earl