RE: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andi Gutmans
OK sounds fine. > -Original Message- > From: Andrei Zmievski [mailto:[EMAIL PROTECTED] > Sent: Monday, July 17, 2006 5:28 PM > To: Andi Gutmans > Cc: 'Zeev Suraski'; 'Marcus Boerger'; 'PHP internals' > Subject: Re: [PHP-DEV] Unicode and fe

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Zeev Suraski
Aren't we both normalizing and lowercasing? Zeev At 02:45 18/07/2006, Andrei Zmievski wrote: We are actually normalizing, but only identifiers. -Andrei On Jul 17, 2006, at 4:08 PM, Andi Gutmans wrote: Looks OK to me. Can we call it ZEND_FETCH_CLASS_NO_LOWERCASE instead of ZEND_FETCH_CLASS_N

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andrei Zmievski
a Unicode expert so my question might be somewhat ignorant.. -Original Message- From: Andrei Zmievski [mailto:[EMAIL PROTECTED] Sent: Monday, July 17, 2006 4:57 PM To: Zeev Suraski Cc: Andi Gutmans; Marcus Boerger; PHP internals Subject: Re: [PHP-DEV] Unicode and fetch class Yes, w

RE: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andi Gutmans
L PROTECTED] > Sent: Monday, July 17, 2006 4:57 PM > To: Zeev Suraski > Cc: Andi Gutmans; Marcus Boerger; PHP internals > Subject: Re: [PHP-DEV] Unicode and fetch class > > Yes, we are. But normalization (in our case) may involve > case-folding (for class/function names), so i

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andrei Zmievski
Yes, we are. But normalization (in our case) may involve case-folding (for class/function names), so it's really a single operation. If you are asking whether we should have 2 flags for it, I don't believe so. -Andrei On Jul 17, 2006, at 4:48 PM, Zeev Suraski wrote: Aren't we both normali

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andrei Zmievski
We are actually normalizing, but only identifiers. -Andrei On Jul 17, 2006, at 4:08 PM, Andi Gutmans wrote: Looks OK to me. Can we call it ZEND_FETCH_CLASS_NO_LOWERCASE instead of ZEND_FETCH_CLASS_NO_NORMALIZE. No biggy but I always think of normalizing as in taking a Unicode string and no

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Marcus Boerger
ginal Message- >> From: Marcus Boerger [mailto:[EMAIL PROTECTED] >> Sent: Monday, July 17, 2006 2:49 PM >> To: Andrei Zmievski >> Cc: Marcus Boerger; Andrei Zmievski; Zeev Suraski; Andi >> Gutmans; internals@lists.php.net >> Subject: Re: [PHP-DEV] Unicode

RE: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andi Gutmans
omagically in PHP. Andi > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Monday, July 17, 2006 2:49 PM > To: Andrei Zmievski > Cc: Marcus Boerger; Andrei Zmievski; Zeev Suraski; Andi > Gutmans; internals@lists.php.net > Subject: Re: [P

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Marcus Boerger
Hello Andrei, looks pretty fine to me, after your treatment, go ahead commit - Andi, Zeev? best regards marcus Monday, July 17, 2006, 9:50:44 PM, you wrote: > Index: Zend/zend_API.c > === > RCS file: /repository/ZendEngine2/zend_

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andrei Zmievski
Of course it would help if I attached the patch.. -Andrei Index: Zend/zend_API.c === RCS file: /repository/ZendEngine2/zend_API.c,v retrieving revision 1.378 diff -p -u -r1.378 zend_API.c --- Zend/zend_API.c 13 Jul 2006 21:27:48

Re: [PHP-DEV] Unicode and fetch class

2006-07-17 Thread Andrei Zmievski
I fixed some bugs and reworked the patch. Please look it over, as I intend to commit it in the next couple of days. The next step would be fixing zend_u_str_case_fold() to do only case folding and having all normalization go through zend_normalize_identifier(). -Andrei On Jul 15, 2006, at 1