Re: [PHP-DEV] RFC: code optimizations

2023-03-14 Thread Ilija Tovilo
Hi > This comment is very, very unnecessary. The message sent to the new > potential maintainers by the outcome of the whole discussion is not very > promising and such cheap irony doesn't help neither. I hope that at least > PHP internals community can learn how to handle such cooperation problem

Re: [PHP-DEV] RFC: code optimizations

2023-03-14 Thread Joerg Sowa
> Seems Uncle Bob with his boy scout rule left the room... This comment is very, very unnecessary. The message sent to the new potential maintainers by the outcome of the whole discussion is not very promising and such cheap irony doesn't help neither. I hope that at least PHP internals community

Re: [PHP-DEV] RFC: code optimizations

2023-03-10 Thread Eugene Sidelnyk
Seems Uncle Bob with his boy scout rule left the room... On Fri, Mar 10, 2023, 2:19 PM Max Kellermann wrote: > On 2023/03/01 13:15, Max Kellermann wrote: > > IMO this is a bug in the process, and I'm trying to fix it. It should > > be allowed to merge small incremental improvements without a d

Re: [PHP-DEV] RFC: code optimizations

2023-03-10 Thread Max Kellermann
On 2023/03/01 13:15, Max Kellermann wrote: > IMO this is a bug in the process, and I'm trying to fix it. It should > be allowed to merge small incremental improvements without a dedicated > RFC. > > This is the first draft of my RFC: > https://wiki.php.net/rfc/code_optimizations My RFC draft i

Re: [PHP-DEV] RFC: code optimizations

2023-03-05 Thread Max Kellermann
On 2023/03/06 00:43, Juris Evertovskis wrote: > The current amount of secondary votes makes it feel daunting. I would > suspect not all voters will think thoroughly about each of the questions. > I suggest that most of these questions could be agreed upon in discussions > before the vote. Casting

RE: [PHP-DEV] RFC: code optimizations

2023-03-05 Thread Juris Evertovskis
The current amount of secondary votes makes it feel daunting. I would suspect not all voters will think thoroughly about each of the questions. I suggest that most of these questions could be agreed upon in discussions before the vote. Maybe the RFC could propose a certain wording of the guidelin

Re: [PHP-DEV] RFC: code optimizations

2023-03-01 Thread Deleu
On Wed, Mar 1, 2023 at 8:15 AM Max Kellermann wrote: > On 2023/03/01 06:37, Max Kellermann wrote: > > Indeed it appears Dmitry is right - code refactoring is generally NOT > > allowed (unless there is an explicit RFC vote, and I havn't seen one). > > IMO this is a bug in the process, and I'm try