Re: [PHP-DEV] zend_u_strtod is slow - possible fix

2006-08-03 Thread Andrei Zmievski
Want to port it to support UChar*? -A On Aug 3, 2006, at 12:24 AM, Derick Rethans wrote: On Wed, 2 Aug 2006, Andrei Zmievski wrote: You'd have to ask Derick. He's the one who added it. :) Note that zend_string_to_double() is not actually used anywhere. I stole it from BSD, and yes... this

Re: [PHP-DEV] zend_u_strtod is slow - possible fix

2006-08-03 Thread Derick Rethans
On Wed, 2 Aug 2006, Andrei Zmievski wrote: > You'd have to ask Derick. He's the one who added it. :) Note that > zend_string_to_double() is not actually used anywhere. I stole it from BSD, and yes... this is really needed because of all the different architectures. Derick -- PHP Internals - P

Re: [PHP-DEV] zend_u_strtod is slow - possible fix

2006-08-02 Thread Andrei Zmievski
You'd have to ask Derick. He's the one who added it. :) Note that zend_string_to_double() is not actually used anywhere. -A On Aug 2, 2006, at 2:12 AM, Matt W wrote: Hi Andrei, Thanks for your reply. Yeah, obviously it'll still be slower than with an already-binary string. :-) But I figur

Re: [PHP-DEV] zend_u_strtod is slow - possible fix

2006-08-02 Thread Matt W
Hi Andrei, Thanks for your reply. Yeah, obviously it'll still be slower than with an already-binary string. :-) But I figured it's better than before, until something better comes along... Unless there were other plans to rewrite it, is there a way to easily (for me! :-)) have it do all the con

Re: [PHP-DEV] zend_u_strtod is slow - possible fix

2006-08-01 Thread Andrei Zmievski
Yes. With your patch applied, the numeric unicode string to double conversion is about 100% slower than from binary strings. If this is acceptable we can commit the patch. Otherwise, we should port zend_strtod() to deal with unicode strings directly. -Andrei On Jul 31, 2006, at 1:58 AM, Matt

[PHP-DEV] zend_u_strtod is slow - possible fix

2006-07-31 Thread Matt W
Hi all, As I was working on upgrading the dec[bin|hex|oct] functions to convert large doubles, I noticed how much slower things were when converting Unicode strings to double. I found that converting the whole thing to string and using regular zend_strtod() was much faster. Then I decided to try