On 17/02/15 23:40, Jan Ehrhardt wrote:
>> Thanks patch looks clean and It compiles, i will start testing it
> Apparently your tests were successful (?):
> http://git.php.net/?p=php-src.git;a=commitdiff;h=8f968c5416e721983c0efda25ec1f393c8df662a
Adrian may have, but I've just wasted 2 hours trying
marius adrian popa in php.internals (Fri, 13 Feb 2015 17:56:28 +0200):
>Thanks patch looks clean and It compiles, i will start testing it
Apparently your tests were successful (?):
http://git.php.net/?p=php-src.git;a=commitdiff;h=8f968c5416e721983c0efda25ec1f393c8df662a
Jan
--
PHP Internals - P
On 13/02/15 16:40, Jan Ehrhardt wrote:
> It still gives some warnings at compile time. Most of them are caused by
>
> ib_link = (ibase_db_link *)zend_fetch_resource2_ex(IBG(default_link),\
> LE_LINK, le_link, le_plink);
>
> warning C4024: 'zend_fetch_resource2_ex' : different types for form
marius adrian popa in php.internals (Fri, 13 Feb 2015 17:56:28 +0200):
>On Fri, Feb 13, 2015 at 11:55 AM, Jan Ehrhardt wrote:
>
>> https://github.com/Jan-E/php-src/commit/8c920a22ac65da485eaf3d2fd27baf2b0406116e
>>
>> Could you test that one? I did it as a sort of PHP7 exercise, but I do
>> not ha
Thanks patch looks clean and It compiles , i will start testing it
On Fri, Feb 13, 2015 at 11:55 AM, Jan Ehrhardt wrote:
> Lester Caine in php.internals (Wed, 11 Feb 2015 12:43:05 +):
> >OK I've got a patch for master, but I know that the changes are not
> >complete!
> >
> >http://hg.lsces.o
Lester Caine in php.internals (Wed, 11 Feb 2015 12:43:05 +):
>OK I've got a patch for master, but I know that the changes are not
>complete!
>
>http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6
This one might be a little bit more complete:
https://github.com/Jan-E/php-src/commit/8c920a22ac65d
Finish the patch and i will apply , also ZEND_FETCH_RESOURCE2 must be
replaced with
zend_fetch_resource2 like it was done in pgsql case
https://github.com/php/php-src/commit/0d4255de30314dbfa32827e044b35543b1ae5a39
On Thu, Feb 12, 2015 at 2:42 PM, Lester Caine wrote:
> On 12/02/15 11:35, Nikit
On 12/02/15 11:35, Nikita Popov wrote:
> I've still got a question about the &string_arg on line 1.9 and if it
> should be changed to a string but that change needs working through the
> following code.
>
>
> Yes, this should be changed to a string. E.g. use the 'S' zpp modifier
> and
On Wed, Feb 11, 2015 at 1:43 PM, Lester Caine wrote:
> On 10/02/15 14:31, Lester Caine wrote:
> > in interbase/ibase_blobs.c
> >
> >> zval *blob_arg, *string_arg;
> >> ibase_blob *ib_blob;
> >>
> >> RESET_ERRMSG;
> >>
> >> if (ZEND_NUM_ARGS() != 2 || zend_get_parameters_ex(2,
On 12/02/15 10:10, Yasuo Ohgaki wrote:
>
> 1.9 +if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> "rr", &blob_arg, &string_arg)) {
>
> I don't read the code and just curious.
> The "string_arg" isn't string? Why you specify "r" (resource)? Is it
> badly named parameter or some ki
Hi Lester,
On Wed, Feb 11, 2015 at 9:43 PM, Lester Caine wrote:
> OK I've got a patch for master, but I know that the changes are not
> complete!
>
> http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6
>
> I've still got a question about the &string_arg on line 1.9 and if it
> should be changed t
On 10/02/15 14:31, Lester Caine wrote:
> in interbase/ibase_blobs.c
>
>> zval *blob_arg, *string_arg;
>> ibase_blob *ib_blob;
>>
>> RESET_ERRMSG;
>>
>> if (ZEND_NUM_ARGS() != 2 || zend_get_parameters_ex(2, &blob_arg,
>> &string_arg) == FAILURE) {
>> WRONG_PARAM_CO
in interbase/ibase_blobs.c
> zval *blob_arg, *string_arg;
> ibase_blob *ib_blob;
>
> RESET_ERRMSG;
>
> if (ZEND_NUM_ARGS() != 2 || zend_get_parameters_ex(2, &blob_arg,
> &string_arg) == FAILURE) {
> WRONG_PARAM_COUNT;
> }
>
> ZEND_FETCH_RESOURC
13 matches
Mail list logo
