Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-23 Thread Marcus Boerger
Hello Pierre, Saturday, February 21, 2009, 2:46:01 PM, you wrote: > On Sat, Feb 21, 2009 at 1:05 PM, Marcus Boerger wrote: >> Hello Pierre, >> >> Thursday, February 19, 2009, 12:22:41 PM, you wrote: >> >>> hi, >> >>> On Thu, Feb 19, 2009 at 11:57 AM, Johannes Schlüter >>> wrote: >> ps. I'

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-21 Thread Pierre Joye
On Sat, Feb 21, 2009 at 1:05 PM, Marcus Boerger wrote: > Hello Pierre, > > Thursday, February 19, 2009, 12:22:41 PM, you wrote: > >> hi, > >> On Thu, Feb 19, 2009 at 11:57 AM, Johannes Schlüter wrote: > >>> ps. I'm aware of the fact that we added some specific APIs in special >>> cases in bug fix

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-21 Thread Marcus Boerger
Hello Pierre, Thursday, February 19, 2009, 12:22:41 PM, you wrote: > hi, > On Thu, Feb 19, 2009 at 11:57 AM, Johannes Schlüter wrote: >> ps. I'm aware of the fact that we added some specific APIs in special >> cases in bug fix releases before, but there's a difference between >> adding APIs an

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-19 Thread Nathan Nobbe
did you guys see the other patch i posted yesterday? i re-read Johannes' first reply yesterday and saw the bit about a second api for a zend_call_method with a variable number of parameters. so a made a new function then re-implemented zend_call_method based on that. heres the patch (easier to re

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-19 Thread Pierre Joye
hi, On Thu, Feb 19, 2009 at 11:57 AM, Johannes Schlüter wrote: > ps. I'm aware of the fact that we added some specific APIs in special > cases in bug fix releases before, but there's a difference between > adding APIs and breaking the ABI of existing, used, stuff. Exactly. To summarize: x.y.z

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-19 Thread Johannes Schlüter
On Thu, 2009-02-19 at 00:14 +0100, Marcus Boerger wrote: > Stuff like this can imo always be added and whether you do > #if PHP_VERSION_ID >= 50300 > or > #if PHP_VERSION_ID >= 50301 > imo doesn't matter much. It does. Up till now we always tried to keep binary compatibility for "bug fix" release

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-18 Thread Marcus Boerger
Hello Nathan, Wednesday, February 18, 2009, 3:31:56 PM, you wrote: > On Wed, Feb 18, 2009 at 6:16 AM, Johannes Schlüter wrote: >> But I don't think that a new limitation is any better: Tomorrow we have >> to change it again as somebody has a reason to use 5 parameters, so if >> it is changed it

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-18 Thread Nathan Nobbe
On Wed, Feb 18, 2009 at 6:16 AM, Johannes Schlüter wrote: > But I don't think that a new limitation is any better: Tomorrow we have > to change it again as somebody has a reason to use 5 parameters, so if > it is changed it should be changed to take any number of arguments and > no fixed limit..

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-18 Thread Johannes Schlüter
On Wed, 2009-02-18 at 11:34 +0300, Antony Dovgal wrote: > > recently, working on an extension, i wanted to call a method w/ 3 params, > > and as you know, zend_call_method only supports 2 parameters at most. i > > came across this thread in the archives, [...] > What happened to call_user_function

Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-18 Thread Antony Dovgal
On 18.02.2009 07:08, Nathan Nobbe wrote: > hi, > > recently, working on an extension, i wanted to call a method w/ 3 params, > and as you know, zend_call_method only supports 2 parameters at most. i > came across this thread in the archives, > > http://marc.info/?l=php-internals&m=12017969031041

[PHP-DEV] zend_call_method() - support for up to 4 parameters

2009-02-17 Thread Nathan Nobbe
hi, recently, working on an extension, i wanted to call a method w/ 3 params, and as you know, zend_call_method only supports 2 parameters at most. i came across this thread in the archives, http://marc.info/?l=php-internals&m=120179690310419&w=2 so i tossed together a quick patch w/ no emalloc