Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread John Coggeshall
Nuno: Do you know when the BC break was with libtidy? I'll need to add a config.m4 check at the very least. John On Wed, 2006-04-19 at 23:13 +0200, Steph Fox wrote: > > I just thought that since we're looking at tidy we might as well update > > the libs on win32 build boxes :) > > Mm but actua

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
I just thought that since we're looking at tidy we might as well update the libs on win32 build boxes :) Mm but actually what's more likely to happen, now that it's turned into a discussion on upgrading, is precisely nothing. AKA the static build won't be fixed because 'there's going to be an

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Edin Kadribasic
Steph Fox wrote: It seems very odd to me there can't just be a one-line fix for something that's broken in 5_1 win32 static build without a whole hoo-ha going down. The extension doesn't build against the new library without fiddling, and nor does it build against the library we actually us

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
Hi John, Being older and wiser than I was this morning: tidySetInCharEncoding tidySetOutCharEncoding tidyOptGetDoc tidyOptGetDocLinksList tidyOptGetNextDocLinks tidyAttrGetById are the only newly introduced functions between the two library versions. The _only_ problem with the current static

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
There _isn't_ a PECL tidy version 2.0...! Steph Fox wrote: Something's odd in the manual then: Note: Tidy 1.0 is just for PHP 4.3.x, while Tidy 2.0 is just for PHP 5. Which refers to ext/tidy version (AFAICT). exactly. The PECL tidy extension version 2.0 doesn't work with PHP 4 because i

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
It seems very odd to me there can't just be a one-line fix for something that's broken in 5_1 win32 static build without a whole hoo-ha going down. The extension doesn't build against the new library without fiddling, and nor does it build against the library we actually use. The difference

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
Steph Fox wrote: Something's odd in the manual then: Note: Tidy 1.0 is just for PHP 4.3.x, while Tidy 2.0 is just for PHP 5. Which refers to ext/tidy version (AFAICT). exactly. The PECL tidy extension version 2.0 doesn't work with PHP 4 because it uses some zend engine 2 specific stuff (OO

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread John Coggeshall
On Wed, 2006-04-19 at 14:27 +0200, Steph Fox wrote: > Really this is down to John Coggeshall (as maintainer) - unless someone else > feels like going and finding a newer version of libtidy and testing it with > the existing extension(s) - e.g. would a newer version also bring other new > functio

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Michael Wallner
Steph Fox wrote: Something's odd in the manual then: Note: Tidy 1.0 is just for PHP 4.3.x, while Tidy 2.0 is just for PHP 5. Which refers to ext/tidy version (AFAICT). Regards, -- Michael - http://dev.iworks.at/ext-http/http-functions.html.gz -- PHP Internals - PHP Runtime Development Mail

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
Nuno, will this also work for 4_3 branch? Yep, the libtidy API hasn't changed. Something's odd in the manual then: Note: Tidy 1.0 is just for PHP 4.3.x, while Tidy 2.0 is just for PHP 5. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
Ah Sorry. I haven't compiled PHP on windows for some time now. Attached is a patch thats fixes the problem. Nuno Latest CVS (SF anon CVS worked for me) doesn't compile with error: ext\tidy\tidy.c(586) : error C2152: 'function' : pointers to functions with different attributes Edin Nuno Lop

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Edin Kadribasic
I mean ext/tidy from 5.1 doesn't compile with this latest version of libtidy. Libtidy itself compiles fine on windows. Edin Edin Kadribasic wrote: > Latest CVS (SF anon CVS worked for me) doesn't compile with error: > > ext\tidy\tidy.c(586) : error C2152: 'function' : pointers to functions > wit

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Edin Kadribasic
Latest CVS (SF anon CVS worked for me) doesn't compile with error: ext\tidy\tidy.c(586) : error C2152: 'function' : pointers to functions with different attributes Edin Nuno Lopes wrote: > answering both e-mails: > >> Nuno, which version of libtidy do you think we should use for bundiling >> w

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
answering both e-mails: Nuno, which version of libtidy do you think we should use for bundiling with the windows distribution? latest CVS. It is stable ATM (but checkout with a developer account, because sourceforge's anonymous cvs servers are currently broken). Nuno, will this also work f

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
Nuno, will this also work for 4_3 branch? >I updated my copy from Edin's collection last week. It's newer than >last year's, but I'm struggling to find any form of 'version' in there >to know exactly what I have in front of me. So what are you talking >about? Update from what, to what, and for

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Edin Kadribasic
Nuno, which version of libtidy do you think we should use for bundiling with the windows distribution? Edin -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
>I updated my copy from Edin's collection last week. It's newer than last >year's, but I'm struggling to find any form of 'version' in there to >know exactly what I have in front of me. So what are you talking about? >Update from what, to what, and for which PHP build? I'm talking about the li

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
>I updated my copy from Edin's collection last week. It's newer than last >year's, but I'm struggling to find any form of 'version' in there to know >exactly what I have in front of me. So what are you talking about? Update >from what, to what, and for which PHP build? I'm talking about the li

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
I updated my copy from Edin's collection last week. It's newer than last year's, but I'm struggling to find any form of 'version' in there to know exactly what I have in front of me. So what are you talking about? Update from what, to what, and for which PHP build? I'm talking about the libtid

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
yOptGetDoc in the export list AT ALL. Just ran a test and found this is illegal syntax :( so back to the drawing board. (Edin: is there some way you know of to do an #ifdef equivalent in these export lists?) - Steph - Original Message - From: "Steph Fox" <[EMAIL PROTE

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
--- From: "Steph Fox" <[EMAIL PROTECTED]> To: "internals" Sent: Wednesday, April 19, 2006 12:34 PM Subject: [PHP-DEV] tiny patch for Tidy This allows static builds under win32 despite the fact that tidyOptGetDoc() doesn't exist in the libtidy.lib we're linkin

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Nuno Lopes
; Sent: Wednesday, April 19, 2006 12:00 PM Subject: Re: [PHP-DEV] tiny patch for Tidy Oops, forget it. The problem with having both PECL and src on board is I assumed I was building against the one with this change in it. I wasn't - I was building against the one that didn't have tidyOpt

Re: [PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
ntax :( so back to the drawing board. (Edin: is there some way you know of to do an #ifdef equivalent in these export lists?) - Steph - Original Message - From: "Steph Fox" <[EMAIL PROTECTED]> To: "internals" Sent: Wednesday, April 19, 2006 12:34 PM Su

[PHP-DEV] tiny patch for Tidy

2006-04-19 Thread Steph Fox
This allows static builds under win32 despite the fact that tidyOptGetDoc() doesn't exist in the libtidy.lib we're linking against. It needs applying to php_tidy.def everywhere libtidy v 2 is used - that is, ext/tidy in CVS HEAD and PHP_5_1, and CVS HEAD pecl/tidy. In all three cases there is