Re: [PHP-DEV] timelib performance fix

2021-08-31 Thread Dmitry Stogov
On Tue, Aug 31, 2021 at 11:58 PM Ben Ramsey wrote: > > Is it solely a bug fix and/or performance improvement? > This is not a bug fix, this is a fix for a performance problem. Thanks. Dmitry.

Re: [PHP-DEV] timelib performance fix

2021-08-31 Thread Kalle Sommer Nielsen
Den tir. 31. aug. 2021 kl. 09.10 skrev Pierre Joye : > It is late in the run to include it, but if RMs are OK, I would be all > for applying it. The lib is bundled and whether the external > repository applies it should not be relevant at this point (also no > activity in 2 years there), or? The e

Re: [PHP-DEV] timelib performance fix

2021-08-31 Thread Ben Ramsey
Pierre Joye wrote on 8/31/21 01:10: > On Mon, Aug 30, 2021 at 8:54 PM Dmitry Stogov wrote: > >> Please, let me know you decision according >> https://github.com/derickr/timelib/pull/99 >> >> This workaround fix makes ~170 times improvement on "new DateTimeZone()" >> and as result visible improvem

Re: [PHP-DEV] timelib performance fix

2021-08-31 Thread Derick Rethans
Hi Dmitry, On Mon, 30 Aug 2021, Dmitry Stogov wrote: > Please, let me know you decision according > https://github.com/derickr/timelib/pull/99 > > This workaround fix makes ~170 times improvement on "new DateTimeZone()" > and as result visible improvement on some real-life apps (e.g Symfony demo

Re: [PHP-DEV] timelib performance fix

2021-08-31 Thread Rowan Tommins
On 31/08/2021 07:10, Pierre Joye wrote: also no activity in 2 years there Possibly you looked at the "latest release" in Github's sidebar, which shows Jan 2019 for some reason, but the most recent tag was actually three weeks ago: https://github.com/derickr/timelib/tags I'll leave Derick t

Re: [PHP-DEV] timelib performance fix

2021-08-30 Thread Pierre Joye
Hi Dmitry, On Mon, Aug 30, 2021 at 8:54 PM Dmitry Stogov wrote: > Please, let me know you decision according > https://github.com/derickr/timelib/pull/99 > > This workaround fix makes ~170 times improvement on "new DateTimeZone()" > and as result visible improvement on some real-life apps (e.g

[PHP-DEV] timelib performance fix

2021-08-30 Thread Dmitry Stogov
Hi Derick, Please, let me know you decision according https://github.com/derickr/timelib/pull/99 This workaround fix makes ~170 times improvement on "new DateTimeZone()" and as result visible improvement on some real-life apps (e.g Symfony demo gets ~7% according to callgrind). This is a huge dif