Re: [PHP-DEV] thread unsafety inventory

2006-11-30 Thread Ron Korving
Ilia, Great work. I posted a bug report at www.sqlite.org. Regards, Ron Korving "Ilia Alshanetsky" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > > On 27-Nov-06, at 3:24 PM, Ron Korving wrote: > > gmtime: (use gmtime_r) > > > > ext/interbase/ibase_query.c on line 679 > > Fixed.

Re: [PHP-DEV] thread unsafety inventory

2006-11-30 Thread Ilia Alshanetsky
On 27-Nov-06, at 3:24 PM, Ron Korving wrote: gmtime: (use gmtime_r) ext/interbase/ibase_query.c on line 679 Fixed. ext/pdo_sqlite/sqlite/src/date.c on line 948 (external code library) This code cannot be reached since we compile libsqlite with date functions. sapi/thttpd_patch on lin

Re: [PHP-DEV] thread unsafety inventory

2006-11-27 Thread Ilia Alshanetsky
On 27-Nov-06, at 3:24 PM, Ron Korving wrote: rand: (use rand_r) ext/mcrypt/mcrypt.c on line 1042 ext/soap/php_http.c on line 467 The first two are now fixed. ext/sqlite/libsqlite/src/encode.c on lines 204, 213 (external code library) These two uses are a non-issue as they are located i

[PHP-DEV] thread unsafety inventory

2006-11-27 Thread Ron Korving
Internals, I have gone through the PHP codebase (latest 5.2 CVS), looking for the use of thread unsafe functions, and I found a number. I have virtually no experience in the PHP codebase, so I can't guarantee there are no false alarms in this, but I think the majority is valid. I noticed that main