Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-22 Thread Kalle Sommer Nielsen
Hi 2009/6/16 Zeev Suraski : > At 17:00 16/06/2009, Daniel Convissor wrote: >> >> Folks: >> >> > I propose the following behavior: "Throw a deprecated warning unless >> > magic quotes are currently enabled and the >> > parameter is to disable them". >> >> The function is going away.  A deprecated w

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Lukas Kahwe Smith
Hi, This seems like a trivial change from the implementation side, so I am not worried about changing this for the "better" even after RC4 (given proper documentation. So here are the choices I see: 1) stay as is .. aka defaults to on while not emiting an E_DEPRECATED, do emit E_DEPRECAT

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Pierre Joye
On Tue, Jun 16, 2009 at 9:10 PM, Greg Beaver wrote: > Hannes Magnusson wrote: >> On Tue, Jun 16, 2009 at 20:59, Greg Beaver wrote: >> >>> Lukas Kahwe Smith wrote: >>> 1) its not about "punishing", its about alerting people that they are relying on stuff that will go away 2) E_DEPRECA

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Greg Beaver
Hannes Magnusson wrote: > On Tue, Jun 16, 2009 at 20:59, Greg Beaver wrote: > >> Lukas Kahwe Smith wrote: >> >>> 1) its not about "punishing", its about alerting people that they are >>> relying on stuff that will go away >>> 2) E_DEPRECATE is for development only and only as a check you en

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Philip Olson
On Jun 16, 2009, at 11:59 AM, Stefan Walk wrote: On 16 Jun 2009, at 20:49, Lukas Kahwe Smith wrote: 1) its not about "punishing", its about alerting people that they are relying on stuff that will go away 2) E_DEPRECATE is for development only and only as a check you enable now and then

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Hannes Magnusson
On Tue, Jun 16, 2009 at 20:59, Greg Beaver wrote: > Lukas Kahwe Smith wrote: >> 1) its not about "punishing", its about alerting people that they are >> relying on stuff that will go away >> 2) E_DEPRECATE is for development only and only as a check you enable >> now and then >> 3) its off in both

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Lukas Kahwe Smith
On 16.06.2009, at 20:59, Greg Beaver wrote: Lukas Kahwe Smith wrote: 1) its not about "punishing", its about alerting people that they are relying on stuff that will go away 2) E_DEPRECATE is for development only and only as a check you enable now and then 3) its off in both of the php.ini's w

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Stefan Walk
On 16 Jun 2009, at 20:49, Lukas Kahwe Smith wrote: 1) its not about "punishing", its about alerting people that they are relying on stuff that will go away 2) E_DEPRECATE is for development only and only as a check you enable now and then 3) its off in both of the php.ini's we will ship wi

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Greg Beaver
Lukas Kahwe Smith wrote: > 1) its not about "punishing", its about alerting people that they are > relying on stuff that will go away > 2) E_DEPRECATE is for development only and only as a check you enable > now and then > 3) its off in both of the php.ini's we will ship with 5.3 OK, then the UPGR

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Pierre Joye
hi Lukas, On Tue, Jun 16, 2009 at 8:49 PM, Lukas Kahwe Smith wrote: > > On 16.06.2009, at 19:39, Greg Beaver wrote: > >> Daniel Convissor wrote: >>> >>> Folks: >>> I propose the following behavior: "Throw a deprecated warning unless magic quotes are currently enabled and the paramet

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Lukas Kahwe Smith
On 16.06.2009, at 19:39, Greg Beaver wrote: Daniel Convissor wrote: Folks: I propose the following behavior: "Throw a deprecated warning unless magic quotes are currently enabled and the parameter is to disable them". The function is going away. A deprecated warning is necessary to aler

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Zeev Suraski
At 17:00 16/06/2009, Daniel Convissor wrote: Folks: > I propose the following behavior: "Throw a deprecated warning unless > magic quotes are currently enabled and the > parameter is to disable them". The function is going away. A deprecated warning is necessary to alert people of this fact, n

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Greg Beaver
Daniel Convissor wrote: > Folks: > >> I propose the following behavior: "Throw a deprecated warning unless >> magic quotes are currently enabled and the >> parameter is to disable them". > > The function is going away. A deprecated warning is necessary to alert > people of this fact, no matter

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Hannes Magnusson
On Tue, Jun 16, 2009 at 16:00, Daniel Convissor wrote: > Folks: > >> I propose the following behavior: "Throw a deprecated warning unless >> magic quotes are currently enabled and the >> parameter is to disable them". > > The function is going away.  A deprecated warning is necessary to alert > peo

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Daniel Convissor
Folks: > I propose the following behavior: "Throw a deprecated warning unless > magic quotes are currently enabled and the > parameter is to disable them". The function is going away. A deprecated warning is necessary to alert people of this fact, no matter how the function is used. Thanks, -

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Keisial
Pierre Joye wrote: > On Tue, Jun 16, 2009 at 12:33 PM, Hannes > Magnusson wrote: > >>> Because in PHP 6 (or next) the function "set_magic_quotes_runtime()" will be >>> removed, so calling it without checking ini_get() will trigger a fatal >>> error, no ? >>> >> And there is the problem. >

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Pierre Joye
On Tue, Jun 16, 2009 at 12:33 PM, Hannes Magnusson wrote: >> Because in PHP 6 (or next) the function "set_magic_quotes_runtime()" will be >> removed, so calling it without checking ini_get() will trigger a fatal >> error, no ? > > And there is the problem. > The recommended way is: > if(get_magic_

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Hannes Magnusson
On Tue, Jun 16, 2009 at 12:24, Olivier B. wrote: > Hannes Magnusson a écrit : >> >> On Tue, Jun 16, 2009 at 10:09, Pierre Joye wrote: >> >>> >>> hi, >>> >>> On Tue, Jun 16, 2009 at 9:46 AM, Lukas Kahwe Smith >>> wrote: >>> On 16.06.2009, at 05:08, Greg Beaver wrote: > >

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Olivier B.
Hannes Magnusson a écrit : On Tue, Jun 16, 2009 at 10:09, Pierre Joye wrote: hi, On Tue, Jun 16, 2009 at 9:46 AM, Lukas Kahwe Smith wrote: On 16.06.2009, at 05:08, Greg Beaver wrote: Hi, in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an E_DEPRECATED. I tho

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Hannes Magnusson
On Tue, Jun 16, 2009 at 10:09, Pierre Joye wrote: > hi, > > On Tue, Jun 16, 2009 at 9:46 AM, Lukas Kahwe Smith wrote: >> >> On 16.06.2009, at 05:08, Greg Beaver wrote: >> >>> Hi, >>> >>> in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an >>> E_DEPRECATED.  I thought all that argum

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Pierre Joye
hi, On Tue, Jun 16, 2009 at 9:46 AM, Lukas Kahwe Smith wrote: > > On 16.06.2009, at 05:08, Greg Beaver wrote: > >> Hi, >> >> in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an >> E_DEPRECATED.  I thought all that argument was resolved to only throw >> E_DEPRECATED for set_magic_q

Re: [PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-16 Thread Lukas Kahwe Smith
On 16.06.2009, at 05:08, Greg Beaver wrote: Hi, in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an E_DEPRECATED. I thought all that argument was resolved to only throw E_DEPRECATED for set_magic_quotes_runtime(1)? This is a major pain if magic_quotes are enabled and you nee

[PHP-DEV] set_magic_quotes_runtime is still E_DEPRECATED

2009-06-15 Thread Greg Beaver
Hi, in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an E_DEPRECATED. I thought all that argument was resolved to only throw E_DEPRECATED for set_magic_quotes_runtime(1)? This is a major pain if magic_quotes are enabled and you need to turn them off to do unserialize or serializ