Re: [PHP-DEV] realpath() caching

2004-09-27 Thread Andi Gutmans
I don't think STAT cache and realpath have to necessarily be merged because there's a big difference. stat()'s do change periodically (i.e. it's very common) as opposed to realpath() which don't. That said, I think if we add cache_flush() for the stat() cache, I see no problem with it also flush

Re: [PHP-DEV] realpath() caching

2004-09-27 Thread Christian Schneider
Sara Golemon wrote: protocol wrappers (many of which are network based). I think it'd make sense to allow clearstatcache() to selectively clear all cache entries, or only entries for wrappers which do not have the is_url bit set. Maybe this should be generalized to a cache_flush() function with e.g

Re: [PHP-DEV] realpath() caching

2004-09-24 Thread Andi Gutmans
Yep, that was my thinking. Andi At 08:29 PM 9/24/2004 +0200, Marcus Boerger wrote: Hello Andi, if we have ini_set("realpath_catch_size") then obviously ini_set("realpath_catch_size", 0) === clearstatcache() without any additional line of code. regards marcus Friday, September 24, 2004, 1:08:14 AM

Re: [PHP-DEV] realpath() caching

2004-09-24 Thread Marcus Boerger
Hello Andi, if we have ini_set("realpath_catch_size") then obviously ini_set("realpath_catch_size", 0) === clearstatcache() without any additional line of code. regards marcus Friday, September 24, 2004, 1:08:14 AM, you wrote: > I don't know if I'd like to make a PHP user-land function for th

Re: [PHP-DEV] realpath() caching

2004-09-24 Thread Vlad Bosinceanu
Sounds a bit hackish - as opposed to most things in php that have a special function. V Andi Gutmans wrote: I don't know if I'd like to make a PHP user-land function for this, especially as it'll get slightly sticky due to this being a TSRM mechanism. Also, as mentioned by Elfyn, it's very unli

Re: [PHP-DEV] realpath() caching

2004-09-23 Thread Andi Gutmans
I don't know if I'd like to make a PHP user-land function for this, especially as it'll get slightly sticky due to this being a TSRM mechanism. Also, as mentioned by Elfyn, it's very unlikely to affect anyone. How about allowing ini_set("realpath_catch_size", ?); during execution. It would chang

Re: [PHP-DEV] realpath() caching

2004-09-22 Thread Elfyn McBratney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Btw, cool patch. :-) I'll see if we can start testing this in an experimental ebuild in Gentoo land. On Wednesday 22 Sep 2004 10:52, Christian Schneider wrote: > Sara Golemon wrote: > >>realpath_cache_ttl - Time to live for cache entry (defa

Re: [PHP-DEV] realpath() caching

2004-09-22 Thread Christian Schneider
Sara Golemon wrote: realpath_cache_ttl - Time to live for cache entry (default 120 seconds; if set to 0 then doesn't refresh). Ah, didn't grok the TTL at first glance that fairly well negates the need for an explicit flush If the FS layout needs to change all one would have to do is turn d

Re: [PHP-DEV] realpath() caching

2004-09-21 Thread Sara Golemon
> realpath_cache_ttl - Time to live for cache entry (default 120 seconds; if > set to 0 then doesn't refresh). > Ah, didn't grok the TTL at first glance that fairly well negates the need for an explicit flush If the FS layout needs to change all one would have to do is turn down the TTL, m

Re: [PHP-DEV] realpath() caching

2004-09-21 Thread Andi Gutmans
It wouldn't be hard to add. I'm indifferent on how much it's really needed because it doesn't happen too often and the server could be restarted (then again some people might not like doing that). Andi At 11:15 AM 9/21/2004 +0800, Alan Knowles wrote: Just a thought, should clearstatcache() force

Re: [PHP-DEV] realpath() caching

2004-09-21 Thread Andi Gutmans
I was asked to provide some more info about this patch. In general, PHP does a realpath() on files (most importantly included files) so that when include_once() and other PHP functionality needs to know if two file paths are identical it will give a definite answer. realpath() itself is quite a

Re: [PHP-DEV] realpath() caching

2004-09-21 Thread Sara Golemon
clearstatcache() is the wrong place to do this, but I certainly agree that the capability to flush the cache should exist. -Sara "Alan Knowles" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Just a thought, should clearstatcache() force the reset of the cache? > I cant think of man

Re: [PHP-DEV] realpath() caching

2004-09-20 Thread Alan Knowles
Just a thought, should clearstatcache() force the reset of the cache? I cant think of many situations where you would re-build directory tree's on the fly, but you never know what to expect from PHP users :) Regards Alan Andi Gutmans wrote: Thanks for pointing out that the attachment didn't make

Re: [PHP-DEV] realpath() caching

2004-09-20 Thread Andi Gutmans
Thanks for pointing out that the attachment didn't make it through. You can find it at: http://snaps.php.net/~andi/realpath_cache2.diff Andi At 06:28 PM 9/20/2004 -0700, Andi Gutmans wrote: Hi, Attached is the promised patch to do realpath() caching. You can set cache size and TTL via the php.ini

[PHP-DEV] realpath() caching

2004-09-20 Thread Andi Gutmans
Hi, Attached is the promised patch to do realpath() caching. You can set cache size and TTL via the php.ini (default is 2 minutes TTL and 16K memory). It doesn't use the SAPI time() but uses the syscall time() because it seemed to be slightly faster but we can adjust it to use the SAPI one if an

Re: Fwd: [PHP-DEV] realpath() caching

2004-07-22 Thread Andrei Zmievski
On Thu, 22 Jul 2004, Andi Gutmans wrote: > Let me know if the attachment doesn't come through again and I'll post it > on the web It didn't. - Andrei -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: Fwd: [PHP-DEV] realpath() caching

2004-07-22 Thread Andi Gutmans
http://snaps.php.net/~andi/ At 03:18 PM 7/22/2004 -0700, Andi Gutmans wrote: Let me know if the attachment doesn't come through again and I'll post it on the web Date: Thu, 22 Jul 2004 14:30:00 -0700 To: [EMAIL PROTECTED] From: Andi Gutmans <[EMAIL PROTECTED]> Subject: [P

Re: Fwd: [PHP-DEV] realpath() caching

2004-07-22 Thread Tom Sommer
Andi Gutmans wrote: Let me know if the attachment doesn't come through again and I'll post it on the web It didn't // Tom -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Fwd: [PHP-DEV] realpath() caching

2004-07-22 Thread Andi Gutmans
Let me know if the attachment doesn't come through again and I'll post it on the web Date: Thu, 22 Jul 2004 14:30:00 -0700 To: [EMAIL PROTECTED] From: Andi Gutmans <[EMAIL PROTECTED]> Subject: [PHP-DEV] realpath() caching Hi guys, Before 5.0.0 we promised we'll get something

Re: [PHP-DEV] realpath() caching

2004-07-22 Thread Andrei Zmievski
Attachment didn't come through. On Thu, 22 Jul 2004, Andi Gutmans wrote: > Hi guys, > > Before 5.0.0 we promised we'll get something together for solving the > performance problems caused by Zend always realpath()'ing include files (in > expand_filepath()). > Attached is a proposed implementati

[PHP-DEV] realpath() caching

2004-07-22 Thread Andi Gutmans
Hi guys, Before 5.0.0 we promised we'll get something together for solving the performance problems caused by Zend always realpath()'ing include files (in expand_filepath()). Attached is a proposed implementation of such a cache. We tried to make it as simple as possible and tests shows that it