Re: [PHP-DEV] primary file realpath change

2006-03-10 Thread Rasmus Lerdorf
Rasmus Lerdorf wrote: After poking this a bit more, it looks like this whole block of code in main.c is redundant. Here is the story: We start our journey on a dark and stormy night in June 2002 with this bug: http://bugs.php.net/17720 This led to this fix: http://cvs.php.net/viewcvs.cgi/

Re: [PHP-DEV] primary file realpath change

2006-03-10 Thread Rasmus Lerdorf
After poking this a bit more, it looks like this whole block of code in main.c is redundant. Here is the story: We start our journey on a dark and stormy night in June 2002 with this bug: http://bugs.php.net/17720 This led to this fix: http://cvs.php.net/viewcvs.cgi/php-src/main/main.c?r1=

Re: [PHP-DEV] primary file realpath change

2006-03-10 Thread Brian J. France
On Mar 10, 2006, at 1:57 AM, Rasmus Lerdorf wrote: Rasmus Lerdorf wrote: Andi Gutmans wrote: Are you sure VCWD_REALPATH doesn't use the realpath cache? It did last time I checked and I think is still the right method to use there... quite #define VCWD_REALPATH(path, real_path) realpath(pa

Re: [PHP-DEV] primary file realpath change

2006-03-09 Thread Andi Gutmans
Seems that needs fixing then (non-TSRM). We should support the realpath cache also in non-TSRM mode. At 10:31 PM 3/9/2006, Rasmus Lerdorf wrote: Andi Gutmans wrote: Are you sure VCWD_REALPATH doesn't use the realpath cache? It did last time I checked and I think is still the right method to us

Re: [PHP-DEV] primary file realpath change

2006-03-09 Thread Rasmus Lerdorf
Rasmus Lerdorf wrote: Andi Gutmans wrote: Are you sure VCWD_REALPATH doesn't use the realpath cache? It did last time I checked and I think is still the right method to use there... quite #define VCWD_REALPATH(path, real_path) realpath(path, real_path) By the way, I agree that expand_filepa

Re: [PHP-DEV] primary file realpath change

2006-03-09 Thread Rasmus Lerdorf
Andi Gutmans wrote: Are you sure VCWD_REALPATH doesn't use the realpath cache? It did last time I checked and I think is still the right method to use there... quite #define VCWD_REALPATH(path, real_path) realpath(path, real_path) -Rasmus -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] primary file realpath change

2006-03-09 Thread Andi Gutmans
Are you sure VCWD_REALPATH doesn't use the realpath cache? It did last time I checked and I think is still the right method to use there... At 09:13 PM 3/9/2006, Brian J. France wrote: Does anybody see a problem with this patch (which is currently against the 5.1.2 release)? expand_filepath wi

[PHP-DEV] primary file realpath change

2006-03-09 Thread Brian J. France
Does anybody see a problem with this patch (which is currently against the 5.1.2 release)? expand_filepath will eventual do a realpath, but it also uses the realpath cache before calling realpath. VCWD_REALPATH just maps directly to realpath and doesn't use the realpath cache so for every