RE: [PHP-DEV] phar bug #65028

2013-08-12 Thread Rajneesh Shetty
1858 From: Ralph Schindler [ra...@ralphschindler.com] Sent: Monday, 5 August 2013 6:46 AM To: internals@lists.php.net Subject: Re: [PHP-DEV] phar bug #65028 > Well, if he's still up to it I think we should list him as a maintainer. > Ralph? Yes, I am ready to get back on this

Re: [PHP-DEV] phar bug #65028

2013-08-04 Thread Ralph Schindler
Well, if he's still up to it I think we should list him as a maintainer. Ralph? Yes, I am ready to get back on this horse. Stas, I will address your questions on my original PR this week, perhaps we can get it to a place where you can close it out. -ralph -- PHP Internals - PHP Runtime Dev

Re: [PHP-DEV] phar bug #65028

2013-08-01 Thread Michael Wallner
On 24 July 2013 18:46, Stas Malyshev wrote: > Hi! > >> As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a >> part of PHP, IMHO, to be without a maintainer. > > Well, if he's still up to it I think we should list him as a maintainer. > Ralph? So are we finally ready to give kar

Re: [PHP-DEV] phar bug #65028

2013-07-24 Thread Stas Malyshev
Hi! > As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a > part of PHP, IMHO, to be without a maintainer. Well, if he's still up to it I think we should list him as a maintainer. Ralph? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-690

Re: [PHP-DEV] phar bug #65028

2013-07-24 Thread Sebastian Bergmann
Am 22.07.2013 10:09, schrieb Stas Malyshev: > P.S.: BTW, who is official phar maintainer now? I'm seeing that last > commit from anybody listed as maintainer is 4 years ago... Is it time > to update ownership? As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a part of PHP, IMHO

Re: [PHP-DEV] phar bug #65028

2013-07-24 Thread Ferenc Kovacs
hi we don't have a maintainer for phar as far as I know. Ralph volunteered(twice) to take over phar but was pretty much ignored. He is the last person that I know looking into the phar code and fixing stuff so maybe he could review your changes. On Mon, Jul 22, 2013 at 10:09 AM, Stas Malyshev wro

[PHP-DEV] phar bug #65028

2013-07-22 Thread Stas Malyshev
Hi! I was looking at bug https://bugs.php.net/bug.php?id=65028 and looks like it happens because phar writes manifest after HALT_COMPILER(); ?> and first 4 bytes of manifest are manifest length (little-endian), but when it read the header, it checks if there's \r\n after ?>. So if length has lowes