Re: [PHP-DEV] offsetof and XtOffsetOf

2015-06-05 Thread Rowan Collins
Levi Morrison wrote on 05/06/2015 14:58: On Thu, Jun 4, 2015 at 11:58 PM, Joe Watkins wrote: Explained here: http://lxr.php.net/xref/PHP_TRUNK/main/php.h#415 On Fri, Jun 5, 2015 at 5:06 AM, Levi Morrison wrote: The macro offsetof is required by the C89 standard to be defined in stddef.h and

Re: [PHP-DEV] offsetof and XtOffsetOf

2015-06-05 Thread Rowan Collins
Joe Watkins wrote on 05/06/2015 15:42: The comment seems to suggest we copied the XtOffset stuff from apache source (which copied it from X), verbatim, is that not explanation enough ? It's not an explanation of *why* it was copied - i.e. why it was needed in the first place. It's not the impl

Re: [PHP-DEV] offsetof and XtOffsetOf

2015-06-05 Thread Joe Watkins
The comment seems to suggest we copied the XtOffset stuff from apache source (which copied it from X), verbatim, is that not explanation enough ? Is there any particular reason to change it ? Cheers Joe On Fri, Jun 5, 2015 at 2:58 PM, Levi Morrison wrote: > On Thu, Jun 4, 2015 at 11:58 PM, Joe

Re: [PHP-DEV] offsetof and XtOffsetOf

2015-06-05 Thread Levi Morrison
On Thu, Jun 4, 2015 at 11:58 PM, Joe Watkins wrote: > Explained here: http://lxr.php.net/xref/PHP_TRUNK/main/php.h#415 > > > On Fri, Jun 5, 2015 at 5:06 AM, Levi Morrison wrote: >> >> The macro offsetof is required by the C89 standard to be defined in >> stddef.h and remains in newer standards. T

Re: [PHP-DEV] offsetof and XtOffsetOf

2015-06-04 Thread Joe Watkins
Explained here: http://lxr.php.net/xref/PHP_TRUNK/main/php.h#415 On Fri, Jun 5, 2015 at 5:06 AM, Levi Morrison wrote: > The macro offsetof is required by the C89 standard to be defined in > stddef.h and remains in newer standards. The macro XtOffsetOf is > non-standard that is as far as I can te

[PHP-DEV] offsetof and XtOffsetOf

2015-06-04 Thread Levi Morrison
The macro offsetof is required by the C89 standard to be defined in stddef.h and remains in newer standards. The macro XtOffsetOf is non-standard that is as far as I can tell a part of the X Toolkit Intrinsics or Xlib. Does anyone know the reasons why we are using the non-standard macro instead of