Re: [PHP-DEV] new PostgreSQL API

2008-07-23 Thread Hartmut Holzgraefe
Hartmut Holzgraefe wrote: I finished testing now, the new test case "27large_object_oid.phpt" tests for the new parameters. The test passes with PostgreSQL 8.4 but fails with older versions as i haven't found a good way to test for the new capabilities in the skip test. i'm now testing by pg_ve

Re: [PHP-DEV] new PostgreSQL API

2008-07-22 Thread Hartmut Holzgraefe
Tatsuo Ishii wrote: I think it should return errors in the case. The intention for the PostgreSQL API is, avoiding automatic oid assigning by PostgreSQL. This is necessary for query based replication tools such as pgpool. Plus, if PostgreSQL fails to assign the specified oid, the transaction will

Re: [PHP-DEV] new PostgreSQL API

2008-07-07 Thread Tatsuo Ishii
> Hartmut Holzgraefe wrote: > > > i've started looking into the patch yesterday, there are still some > > small issues with it though ... i'll provide you with more detailed > > comments later today or early tomorrow ... > > open questions: > > - should the functions return an error if using

Re: [PHP-DEV] new PostgreSQL API

2008-07-07 Thread Hartmut Holzgraefe
Hartmut Holzgraefe wrote: i've started looking into the patch yesterday, there are still some small issues with it though ... i'll provide you with more detailed comments later today or early tomorrow ... open questions: - should the functions return an error if using the specified oid i

Re: [PHP-DEV] new PostgreSQL API

2008-07-06 Thread Hartmut Holzgraefe
Hello Tatsuo-san Can anybody review my patches? I need to commit the patches and want to work on 5.3 and 6.0. i've started looking into the patch yesterday, there are still some small issues with it though ... i'll provide you with more detailed comments later today or early tomorrow ... -

Re: [PHP-DEV] new PostgreSQL API

2008-07-04 Thread Tatsuo Ishii
Can anybody review my patches? I need to commit the patches and want to work on 5.3 and 6.0. -- Tatsuo Ishii SRA OSS, Inc. Japan > Sorry for delay. Here is the revised patches. > > I marged pg_lo_import_with_oid() into pg_lo_import(). > -- > Tatsuo Ishii > SRA OSS, Inc. Japan > > > > On 17.04.20

Re: [PHP-DEV] new PostgreSQL API

2008-07-01 Thread Tatsuo Ishii
Sorry for delay. Here is the revised patches. I marged pg_lo_import_with_oid() into pg_lo_import(). -- Tatsuo Ishii SRA OSS, Inc. Japan > > On 17.04.2008 18:50, Tatsuo Ishii wrote: > > > Here are the patches against 5.2 HEAD. > > > > First of all, please use `diff -u`, not just `diff` - unified

Re: [PHP-DEV] new PostgreSQL API (was Re: [PHP-DEV] CVS Account Request)

2008-05-25 Thread Pierre Joye
On Sun, May 25, 2008 at 4:06 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Tatsuo, > > I never saw an update on this patch, is there any? Also did you ever > apply for an account? Please do the following: > 1) Change your patch with Tony's comment in mind (don't add > lo_import_with_oid)

Re: [PHP-DEV] new PostgreSQL API (was Re: [PHP-DEV] CVS Account Request)

2008-05-25 Thread Marcus Boerger
Hello Tatsuo, I never saw an update on this patch, is there any? Also did you ever apply for an account? Please do the following: 1) Change your patch with Tony's comment in mind (don't add lo_import_with_oid) 2) Resend the updated patch in unified format (diff -u) 3) Provide tests 4) Apply for

[PHP-DEV] new PostgreSQL API (was Re: [PHP-DEV] CVS Account Request)

2008-04-23 Thread Tatsuo Ishii
> On 17.04.2008 18:50, Tatsuo Ishii wrote: > > Here are the patches against 5.2 HEAD. > > First of all, please use `diff -u`, not just `diff` - unified diffs are much > more readable. Ok. I'll do it next time. > > Modified API's are: > > > > 1) pg_lo_create now accepts an optional parameter (l