Re: [PHP-DEV] merging test improvement to PHP_5_4

On Thu, Jan 19, 2012 at 8:30 PM, Stas Malyshev wrote: > Hi! > > > I fixed > https://bugs.php.net/bug.php?**id=52078, >> I would like to add the test >> improvement to the 5.4 branch also, is it ok to commit, or should I wait >> the release with it? >> > > P

Re: [PHP-DEV] merging test improvement to PHP_5_4

Hi! I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test improvement to the 5.4 branch also, is it ok to commit, or should I wait the release with it? Please hold it, we are announcing RC6 soon and plan to release in 2 weeks, in this period I'd like to keep the SVN as s

Re: [PHP-DEV] merging test improvement to PHP_5_4

And this is why I asked it. "The following may be considered for inclusion: - Unit tests & test fixes .. Please still ask RMs for approval prior to committing even if your patch falls into these categories." On Thu, Jan 19, 2012 at 8:12 PM, Rafael Kassner wrote: > I guess 5.4 branch is under c

Re: [PHP-DEV] merging test improvement to PHP_5_4

I guess 5.4 branch is under code freeze. http://marc.info/?l=php-internals&m=132617955007428&w=2 On Thu, Jan 19, 2012 at 5:07 PM, Ferenc Kovacs wrote: > Hi, > > I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the > test > improvement to the 5.4 branch also, is it ok to commit

[PHP-DEV] merging test improvement to PHP_5_4

Hi, I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test improvement to the 5.4 branch also, is it ok to commit, or should I wait the release with it? see http://svn.php.net/viewvc?view=revision&revision=322460 -- Ferenc Kovács @Tyr43l - http://tyrael.hu