[PHP-DEV] internal hashtables [patch included]

2003-11-09 Thread Cristiano Duarte
Hi all, I guess I found a bug at "zend_compile.c". IMHO when you want to create an internal hashtable, that will be filled with internal zvals (malloc'ed instead of emalloc'ed), you should pass the "internal zval destructor" to the hashtable initialization function. Currently, "zend_compile.c"

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-28 Thread Cristiano Duarte
Derick Rethans wrote: Can you please not send uuencoded stuff but just attach the files as plain text? Sorry Derick, I didn't mean to. :-( The patch is attached as plain text now. Cristiano Duarte ? php-src/ZendEngine1 Index: php-src/Zend/zend_alloc.c ==

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-28 Thread Cristiano Duarte
> Can you please not send uuencoded stuff but just attach the files as > plain text? Sorry Derick, I didn't mean to. The patch is now included as plain text. Cristiano Duarte -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-28 Thread Cristiano Duarte
> Can you please not send uuencoded stuff but just attach the files as > plain text? Sorry Derick, I didn't mean to. The patch is now included as plain text. Cristiano Duarte -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-28 Thread Derick Rethans
On Mon, 27 Oct 2003, Cristiano Duarte wrote: > Oops, I figure out that the patch was incorrect, since the function call > should be "zend_hash_destroy" instead of "zend_hash_clean". Sorry. :-p > New patch included. > Now the memory leaks are gone forever ! Can you please not send uuencoded stuff

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-27 Thread Cristiano Duarte
Oops, I figure out that the patch was incorrect, since the function call should be "zend_hash_destroy" instead of "zend_hash_clean". Sorry. :-p New patch included. Now the memory leaks are gone forever ! Cristiano Duarte begin 666 ze2_internal_symtables.patch M/R!P:' MF5N M9%]A;&QO8RYC"CT]/3T]/3

[PHP-DEV] internal hashtables [patch included]

2003-10-26 Thread Cristiano Duarte
Hi all, Just to remind about my problem: After updating from latest CVS I still had problems with internal hashtables. I want to make internal class constants and the engine reports memory leaks. So I made this patch wich works for me and removed all memory leaks regarding hashtables. This patch

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-26 Thread Cristiano Duarte
Hi Andi, In fact Moriyoshi pointed out this problem in hist "Registering constants to internal classes (ZE2)" message: http://www.zend.com/lists/php-dev/200307/msg00023.html The code I provided fix this problem, if it's a problem... Cristiano Duarte -- PHP Internals - PHP Runtime Development M

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-26 Thread Cristiano Duarte
"Andi Gutmans" <[EMAIL PROTECTED]> escreveu na mensagem news:[EMAIL PROTECTED] > This doesn't look right. Shouldn't you make sure that module shutdown frees > the hashtables? You can change the dtor if you need. > I'm sorry but I don't quite understand what made you come up with this > solution. Ma

Re: [PHP-DEV] internal hashtables [patch included]

2003-10-26 Thread Andi Gutmans
At 02:53 PM 10/26/2003 -0200, Cristiano Duarte wrote: Hi all, Just to remind about my problem: After updating from latest CVS I still had problems with internal hashtables. I want to make internal class constants and the engine reports memory leaks. So I made this patch wich works for me and remov