Re: [PHP-DEV] imap4 search criteria

2010-02-12 Thread Dominik Gehl
Hi, thanks for the feedback ! Let me know if you have other ideas ... I'm really open to make changes to the patch ! Thanks again, Dominik On 2010-02-12, at 10:47 AM, Pierre Joye wrote: > hi, > > There is but I'm not sure these new functions are the way to go. Also > we have been busy with re

Re: [PHP-DEV] imap4 search criteria

2010-02-12 Thread Pierre Joye
hi, There is but I'm not sure these new functions are the way to go. Also we have been busy with releases lately, just in case you don't follow the lists too closely, be patient :) Cheers, On Fri, Feb 12, 2010 at 3:02 PM, Dominik Gehl wrote: > Hi, > > I was just wondering if there was any inter

Re: [PHP-DEV] imap4 search criteria

2010-02-12 Thread Dominik Gehl
Hi, I was just wondering if there was any interest to get this enhancement into the PHP IMAP extension. Should I re-sent the patch as an attachment ? Thanks Dominik On 2010-02-04, at 7:01 PM, Dominik Gehl wrote: >>> $pgm = imap_searchprogram_new(); >>> imap_searchprogram_criteria($pgm1,"DRAFT

Re: [PHP-DEV] imap4 search criteria

2010-02-04 Thread Dominik Gehl
>> $pgm = imap_searchprogram_new(); >> imap_searchprogram_criteria($pgm1,"DRAFT SMALLER 34567 HEADER Message-Id >> FROM domi...@dokdok.com"); > > I assume you meant '$pgm' above? You are absolutely right ! In fact, you can also set every parameter in its own imap_searchprogram_criteria call,

Re: [PHP-DEV] imap4 search criteria

2010-02-04 Thread Dominik Gehl
Here's a new version of the patch. It allows the usage of the following style of code: $pgm = imap_searchprogram_new(); imap_searchprogram_criteria($pgm1,"DRAFT SMALLER 34567 HEADER Message-Id FROM domi...@dokdok.com"); imap_search($mbox,$pgm)); Dominik diff --git a/external/php-5.2.12/ext/

Re: [PHP-DEV] imap4 search criteria

2010-02-04 Thread Dominik Gehl
Here's the patch inline: diff -u --recursive ../orig/php-5.2.12/ext/imap/php_imap.c ./ext/imap/php_imap.c --- ../orig/php-5.2.12/ext/imap/php_imap.c 2009-09-22 14:18:57.0 -0400 +++ ./ext/imap/php_imap.c 2010-02-03 14:16:41.0 -0500 @@ -152,6 +152,9 @@ PHP_FE(imap

Re: [PHP-DEV] imap4 search criteria

2010-02-03 Thread Dominik Gehl
Hi, I just checked the mailinglist archive (http://news.php.net/php.internals/46939) and you're right, the attachment was missing, even though it's in my sent items ... is there some list policy which rejects attachments ? Dominik On 2010-02-03, at 3:08 PM, Pierre Joye wrote: > hi, > > Can

Re: [PHP-DEV] imap4 search criteria

2010-02-03 Thread Pierre Joye
hi, Can you send patches as attachment please? Also I like to think again about a nicer approach. As your proposal works, it sounds like multiple calls could be avoided. Cheers, On Wed, Feb 3, 2010 at 8:37 PM, Dominik Gehl wrote: > Attached is a patch which would allow the usage of most of the

Re: [PHP-DEV] imap4 search criteria

2010-02-03 Thread Dominik Gehl
Attached is a patch which would allow the usage of most of the IMAP4 search criteria. Please let me know if I should contact someone else (IMAP extension maintainer(s) ?) regarding this ... Dominik On 2010-02-02, at 4:14 PM, Dominik Gehl wrote: > I continued thinking about this and came up wi

Re: [PHP-DEV] imap4 search criteria

2010-02-02 Thread Dominik Gehl
I continued thinking about this and came up with the idea of adding a new resource 'imap_searchpgm' to the imap extension, which would then have quite a good number of new functions: imap_searchprogram_new, imap_searchprogram_sentsince, imap_searchprogram_since, imap_searchprogram_before, imap_

Re: [PHP-DEV] imap4 search criteria

2010-02-01 Thread Dominik Gehl
Thanks a lot for your reply. I also found a second bug report related to this: http://bugs.php.net/bug.php?id=21168 Now, how about adding an imap_newsearchpgm function to the PHP imap extension which would do a call to mail_nsewsearchpgm inside c-client and return a structure allowing to contru

Re: [PHP-DEV] imap4 search criteria

2010-01-30 Thread Joey Smith
There's an open bug on this, #15238 (http://bugs.php.net/bug.php?id=15238&;). I'm sure patches would be welcomed. On Fri, Jan 29, 2010 at 03:49:18PM -0500, Dominik Gehl wrote: > Hi, > > I noticed that the imap extension seems to support only IMAP2 search criteria. > > This is caused by the fact

[PHP-DEV] imap4 search criteria

2010-01-29 Thread Dominik Gehl
Hi, I noticed that the imap extension seems to support only IMAP2 search criteria. This is caused by the fact that in ext/imap/php_imap.c, the imap_search function uses a call to mail_criteria. And the University of Washington IMAP toolkit mentions in docs/internal.txt: SEARCHPGM *mail_criteria