Re: [PHP-DEV] function registration patch

2003-03-19 Thread Andrei Zmievski
On Wed, 19 Mar 2003, Andi Gutmans wrote: > If the memory manager is usable at this point (I think it is) then you > should use do_alloca() and free_alloca() instead of malloc()/free(). That's a good tip. But what do you think about the issue in general? On one hand, lowercasing function names/key

Re: [PHP-DEV] function registration patch

2003-03-19 Thread Andi Gutmans
If the memory manager is usable at this point (I think it is) then you should use do_alloca() and free_alloca() instead of malloc()/free(). Andi At 04:54 PM 3/18/2003 -0500, Andrei Zmievski wrote: Currently when registering functions, the unmodified function name is used as the key for the funct

Re: [PHP-DEV] function registration patch

2003-03-19 Thread Ronald Chmara
On Tuesday, March 18, 2003, at 03:07 PM, Sterling Hughes wrote: PS: or, *gasp* drop case-sensitivity. For which I'm an enormous +1. :) Aw, and steal enormous hours from consultants like me who make mad dollars from running grep -i ? How cruel. :-) -Bop -- PHP Internals - PHP Runtime Developm

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Sterling Hughes
On Tue, 2003-03-18 at 17:21, Andrei Zmievski wrote: > On Tue, 18 Mar 2003, Sterling Hughes wrote: > > You're missing my point. Your patch doesn't allow for one to use > > get_constructor and get_method handlers to implement case-sensitive > > handlers, as you are lowercasing the stuff on insert, t

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Andrei Zmievski
On Tue, 18 Mar 2003, Derick Rethans wrote: > > You're missing my point. Your patch doesn't allow for one to use > > get_constructor and get_method handlers to implement case-sensitive > > handlers, as you are lowercasing the stuff on insert, the patch is > > limiting. > > > > I think the best sol

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Andrei Zmievski
On Tue, 18 Mar 2003, Sterling Hughes wrote: > You're missing my point. Your patch doesn't allow for one to use > get_constructor and get_method handlers to implement case-sensitive > handlers, as you are lowercasing the stuff on insert, the patch is > limiting. I already said that my patch sucks,

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Derick Rethans
On Tue, 18 Mar 2003, Sterling Hughes wrote: > On Tue, 2003-03-18 at 17:10, Andrei Zmievski wrote: > > > > I realize that I can overload get_constructor and get_method handlers > > and do all that stuff. But, seriously, this is screwed up. Given the > > situation where class is "GtkButton", if I s

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Sterling Hughes
On Tue, 2003-03-18 at 17:10, Andrei Zmievski wrote: > On Tue, 18 Mar 2003, Sterling Hughes wrote: > > Don't do that. :) > > > > The other problem is (besides what derick said) with Ze2 it is not > > assured that accesses will be lowercased, that's an optional thing. One > > can overload classes,

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Marcus Börger
At 22:57 18.03.2003, Derick Rethans wrote: On Tue, 18 Mar 2003, Andrei Zmievski wrote: > Currently when registering functions, the unmodified function name is > used as the key for the function table. This leads to problems when an > extension class has a constructor that is not all lowercased. Fo

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Andrei Zmievski
On Tue, 18 Mar 2003, Sterling Hughes wrote: > Don't do that. :) > > The other problem is (besides what derick said) with Ze2 it is not > assured that accesses will be lowercased, that's an optional thing. One > can overload classes, and be CS (I do it with ext/mono). I realize that I can overloa

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Sterling Hughes
On Tue, 2003-03-18 at 16:57, Andrei Zmievski wrote: > Grr. Totally slipped my mind that with this patch, the original > function names will be lost when doing get_class_methods() and similar > stuff. Any other suggestions? > Don't do that. :) The other problem is (besides what derick said) with

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Andrei Zmievski
Grr. Totally slipped my mind that with this patch, the original function names will be lost when doing get_class_methods() and similar stuff. Any other suggestions? On Tue, 18 Mar 2003, Andrei Zmievski wrote: > Currently when registering functions, the unmodified function name is > used as the key

Re: [PHP-DEV] function registration patch

2003-03-18 Thread Derick Rethans
On Tue, 18 Mar 2003, Andrei Zmievski wrote: > Currently when registering functions, the unmodified function name is > used as the key for the function table. This leads to problems when an > extension class has a constructor that is not all lowercased. For > example: > > function_entry php_gtk_bu

[PHP-DEV] function registration patch

2003-03-18 Thread Andrei Zmievski
Currently when registering functions, the unmodified function name is used as the key for the function table. This leads to problems when an extension class has a constructor that is not all lowercased. For example: function_entry php_gtk_button_functions[] = { PHP_FE("GtkButton", NULL), ... }