RE: [PHP-DEV] float ops and _controlfp_s

2009-06-15 Thread Garrett Serack
Hey Christian, Uh, my fault false alarm. The fix that went in a while back did indeed fix the problem. Garrett -Original Message- From: Christian Seiler [mailto:chris...@gmx.net] Sent: Saturday, June 13, 2009 11:01 AM To: Pierre Joye Cc: php-dev List Subject: Re: [PHP-DEV] float

Re: [PHP-DEV] float ops and _controlfp_s

2009-06-13 Thread Pierre Joye
hi, On Sat, Jun 13, 2009 at 8:01 PM, Christian Seiler wrote: > This ensures that FPUs on x86 systems are definitely in double precision > mode. The default situation on Windows with MSVC is that the FPU is > already in double precision setting as far as I've tested it - however > there are situat

Re: [PHP-DEV] float ops and _controlfp_s

2009-06-13 Thread Christian Seiler
Hi Pierre, (Btw. you got the wrong Christian as CC. ;-)) > There is still a significant performance impact due to _controlfp_s > usage. Huh? After the modification I made this should only called once (!) at PHP startup Or did we miss something? Anyway, calling it once should not cause any perfor

[PHP-DEV] float ops and _controlfp_s

2009-06-13 Thread Pierre Joye
hi Christian, There is still a significant performance impact due to _controlfp_s usage. I would like to remove it, but before I would also like to know why you introduced it in the 1st place. The tests pass with or without changing the fp on almost each fp ops (sigh :). Can you explain why we ne