Re: [PHP-DEV] fix for bug #26696

2004-01-13 Thread Jon Parise
On Tue, Jan 13, 2004 at 05:27:05PM -0500, Sterling Hughes wrote: > Ok, attached is a diff that properly fixes the problem. [..] > /* perform the equivalent of equivalent of a While you're in there, could you fix the double occurrence double occurrence in this comm

Re: [PHP-DEV] fix for bug #26696

2004-01-13 Thread Sterling Hughes
Ok, attached is a diff that properly fixes the problem. -Sterling > At 04:06 PM 1/13/2004 -0500, Sterling Hughes wrote: > >> Are you sure this is OK? It seems strange that string offsets don't need > >> any unlocking. It might mean we have a problem someplace else and that > >> you're fixing the

Re: [PHP-DEV] fix for bug #26696

2004-01-13 Thread Andi Gutmans
At 04:06 PM 1/13/2004 -0500, Sterling Hughes wrote: > Are you sure this is OK? It seems strange that string offsets don't need > any unlocking. It might mean we have a problem someplace else and that > you're fixing the cause and not the source of the problem (although I > haven't had time to dig d

Re: [PHP-DEV] fix for bug #26696

2004-01-13 Thread Sterling Hughes
> Are you sure this is OK? It seems strange that string offsets don't need > any unlocking. It might mean we have a problem someplace else and that > you're fixing the cause and not the source of the problem (although I > haven't had time to dig deep). > In general, consider the following code:

Re: [PHP-DEV] fix for bug #26696

2004-01-13 Thread Andi Gutmans
Are you sure this is OK? It seems strange that string offsets don't need any unlocking. It might mean we have a problem someplace else and that you're fixing the cause and not the source of the problem (although I haven't had time to dig deep). In general, consider the following code: $a = "Foo"

[PHP-DEV] fix for bug #26696

2004-01-13 Thread Sterling Hughes
Hey, I've attached a fix for an engine level crash in switch() when it is used with string offsets. This eliminates a double-free and valgrind reports that no new leaks have been introduced. -Sterling Index: zend_execute.c === RCS f