Re: [PHP-DEV] feat(pdo): add `clearParams` method

2021-05-04 Thread Juanra GM
Hello Kamil, thanks you for your reply. I am going to enumerate the answers. 1. `PDOStatement::clearParams` should reset the statament params ( https://github.com/php/php-src/blob/31c74aaeebf3af3c87e3981703f9f775c65600b9/ext/pdo/pdo_stmt.c#L406-L410 ). 2. Recreate the prepared statement is very c

Re: [PHP-DEV] feat(pdo): add `clearParams` method

2021-05-04 Thread Kamil Tekiela
Hi Juanra, Thanks for sharing your interest in improving PHP. Your proposal is very unclear at the moment. What do you think this function should do? Why can't you just recreate the prepared statement? What performance hit are you talking about? I don't see how such a function would be useful, but

[PHP-DEV] feat(pdo): add `clearParams` method

2021-05-04 Thread Juanra GM
Hi everybody. Currently it is not possible to clear the PDOStatement params, so it would be useful to add a method for it. Why? `PDOStatement::execute` admits the `$input_parameters` argument, but all values are passed as `PDO::PARAM_STR` and that hit a performance problem at MariaDB. The fix it