Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

Ok fair enough, will revert it. Cheers. On Wed, 29 Jan 2025 at 12:04, Jakub Zelenka wrote: > > > > On Wed, Jan 29, 2025 at 4:22 AM David CARLIER wrote: >> >> Hi, >> >> Working on this PR #17440, I wanted to ask if the BC from these two calls >> were ok because : >> >> Before >> >> function sock

Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

On Wed, Jan 29, 2025 at 4:22 AM David CARLIER wrote: > Hi, > > Working on this PR #17440 , I > wanted to ask if the BC from these two calls > were ok because : > > Before > > function socket_getsockname(Socket $socket, &$address, *&$port = null*): > bool

Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

Am 29.01.2025 um 04:20 schrieb David CARLIER : > Working on this PR #17440, I wanted to ask if the BC from these two calls > were ok because : > > Before > function socket_getsockname(Socket $socket, &$address, &$port = null): > bool {} > > After > function socket_getsockname(Socket

[PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

Hi, Working on this PR #17440 , I wanted to ask if the BC from these two calls were ok because : Before function socket_getsockname(Socket $socket, &$address, *&$port = null*): bool {} After function socket_getsockname(Socket $socket, &$address, *?int