Re: [PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-12-31 Thread Christoph M. Becker
On 31.12.2024 at 16:54, Giovanni Giacobbi wrote: > The idea being, can we provide the most expensive operation, that is basic > pixel by pixel comparison, as native function? Otherwise we keep discussing > bikeshedding and years go by without this being available. This does not > stop future more

Re: [PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-12-31 Thread Giovanni Giacobbi
On Tue, Dec 31, 2024, 13:42 Christoph M. Becker wrote: > On 11.07.2024 at 11:35, Giovanni Giacobbi wrote: > > > The recent PR #14877 [1] proposes to add the imagecompare gd function > that > > mimics the gdImageCompare function from libgd. I always thought that a > > pixel-by-pixel matching funct

Re: [PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-12-31 Thread Christoph M. Becker
On 11.07.2024 at 11:35, Giovanni Giacobbi wrote: > The recent PR #14877 [1] proposes to add the imagecompare gd function that > mimics the gdImageCompare function from libgd. I always thought that a > pixel-by-pixel matching function for two images was a big missing feature > in PHP, as the corres

Re: [PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-07-11 Thread Pierre Joye
hi, as I mentioned in the PR, this is an old function which we did not touch for bc reasons. I also linked a better image comparison function used for the gd tests suite. It covers exaxf match which is what it seems you are aiming to get. Additionally that function also return an image with the

[PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-07-11 Thread Giovanni Giacobbi
The recent PR #14877 [1] proposes to add the imagecompare gd function that mimics the gdImageCompare function from libgd. I always thought that a pixel-by-pixel matching function for two images was a big missing feature in PHP, as the corresponding userland implementation is really, REALLY slow. T