Re: [PHP-DEV] ext/date arguments handling

2014-09-22 Thread Florian Margaine
Hi Derick, Thanks for your answer! Indeed, I did plan on doing another PR for 5.6 while keeping ZEND_ARG_INFO. I'll review your notes and take care of them. Regards, *Florian Margaine* On Mon, Sep 22, 2014 at 1:29 PM, Derick Rethans wrote: > Hi Florian, > > On Sun, 21 Sep 2014, Florian Marga

Re: [PHP-DEV] ext/date arguments handling

2014-09-22 Thread Derick Rethans
Hi Florian, On Sun, 21 Sep 2014, Florian Margaine wrote: > I specifically mean to ask @derick about this issue I'm having, since > he is the maintainer of ext/date. > > I wrote this pull request for the DateTimeZone::getOffset method to > accept a DateTimeInterface instead of a DateTime object

[PHP-DEV] ext/date arguments handling

2014-09-21 Thread Florian Margaine
Hi list, I specifically mean to ask @derick about this issue I'm having, since he is the maintainer of ext/date. I wrote this pull request for the DateTimeZone::getOffset method to accept a DateTimeInterface instead of a DateTime object: https://github.com/php/php-src/pull/831 Instead of using Z