Re: [PHP-DEV] embedded libmagic (from file)

2011-03-22 Thread Pierre Joye
why don't you publish it then? So we can review it and maybe apply it already. On Mon, Mar 21, 2011 at 9:13 PM, Scott MacVicar wrote: > I have a diff sitting that I did yesterday that upgrades us to the > latest libmagic, it supports the new magic file format and updates > that bundle. But that's

Re: [PHP-DEV] embedded libmagic (from file)

2011-03-22 Thread sean finney
On Mon, Mar 21, 2011 at 11:06:28PM -0600, Raphael Geissert wrote: > It's easy to understand the wish of hacking libmagic to provide some more > features, but it would be great to keep the divergence to the strict > minimum. And ideally we could find some kind of technical solution/compromise tha

Re: [PHP-DEV] embedded libmagic (from file)

2011-03-21 Thread Raphael Geissert
Scott MacVicar wrote: > I have a diff sitting that I did yesterday that upgrades us to the > latest libmagic, it supports the new magic file format and updates > that bundle. But that's all. > > I'm also against allowing the non-php version. Yes it's a fork but > unfortunately it's for the best.

Re: [PHP-DEV] embedded libmagic (from file)

2011-03-21 Thread Scott MacVicar
I have a diff sitting that I did yesterday that upgrades us to the latest libmagic, it supports the new magic file format and updates that bundle. But that's all. I'm also against allowing the non-php version. Yes it's a fork but unfortunately it's for the best. - Scott On 21 March 2011 10:12, P

Re: [PHP-DEV] embedded libmagic (from file)

2011-03-21 Thread Pierre Joye
hi, Many incompatibilities and features are not available upstream. The more we work on it the more differences we have. I have to strongly (really strongly) discourage any kind of hacks to allow external libmagic usage. That will only limit the features available to the PHP users, like stream sup