Re: [PHP-DEV] easter_date() II

2007-01-23 Thread Pierre
On 1/23/07, Oliver Block <[EMAIL PROTECTED]> wrote: Hello Pierre, a bug report will be no problem.:) Regarding a patch: timezone information needs to be accessible from within ext/calendar/easter.c if I got it right. The easiest way is to call php_mktime/PHP_FUNCTION(mktime) from within easter_

Re: [PHP-DEV] easter_date() II

2007-01-23 Thread Oliver Block
Hello Pierre, a bug report will be no problem.:) Regarding a patch: timezone information needs to be accessible from within ext/calendar/easter.c if I got it right. The easiest way is to call php_mktime/PHP_FUNCTION(mktime) from within easter_date() - but is that possible/allowed/welcome? Re

Re: [PHP-DEV] easter_date() II

2007-01-22 Thread Pierre
Hi Oliver, Report a bug using bugs.php.net (with a link to the patch diff -up :) This way it will not get lost in the internals archive. On 1/22/07, Oliver Block <[EMAIL PROTECTED]> wrote: Hello, easter_date() returns a timestamp produced by C's mktime(). (ext/calendar/easter.c:111):

[PHP-DEV] easter_date() II

2007-01-22 Thread Oliver Block
Hello, easter_date() returns a timestamp produced by C's mktime(). (ext/calendar/easter.c:111): Z_LVAL_P(return_value) = mktime(&te); AFAIK mktime() (time.h) is different to php's mktime() as it does not consider php's timezones, i,e, C's mktime does always return a timestamp o