Re: [PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-20 Thread Stas Malyshev
Hi! > The idea of the fix is fine (I didn't check all the related changes in > PHP extensions). > I think it must be included into 5.5. Thanks for reviewing it! If I don't head any objections in next couple of days, I'll merge it to 5.5. -- Stanislav Malyshev, Software Architect SugarCRM: http:

Re: [PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-20 Thread Dmitry Stogov
Hi Stas, The idea of the fix is fine (I didn't check all the related changes in PHP extensions). I think it must be included into 5.5. Thanks. Dmitry. On Tue, Feb 19, 2013 at 1:23 PM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produc

Re: [PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-19 Thread Dmitry Stogov
Hi Stas, I'll take a look tomorrow or after tomorrow. Sorry, quite busy. Thanks. Dmitry. On Tue, Feb 19, 2013 at 1:23 PM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlik

Re: [PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-19 Thread Levi Morrison
> I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlike > regular variables that do. I've been bitten by this from time to time. A notice would have been nice. -- PHP Internals - PHP Runtime Development Mai

Re: [PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-19 Thread Sherif Ramadan
On Tue, Feb 19, 2013 at 4:23 AM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlike > regular variables that do. > > Unfortunately, this fix seems to require changing signatu

[PHP-DEV] bug 49348 - notice on $this->undefined++

2013-02-19 Thread Stas Malyshev
Hi! I've created a pull to fix bug 49348 - when undefined properties do not produce a notice when doing something like $this->undefined++, unlike regular variables that do. Unfortunately, this fix seems to require changing signature of get_property_ptr_ptr(), adding fetch type, which makes it imp