Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-04 Thread Jay Smith
Glad to see it's finally working. I was never able to get those errors, but it probably had something to do with the thread pooling you had configured. And seeing as it's working now, I guess I don't need to bother trying to get them. J Uwe Schindler wrote: > On my solaris box the fix does it.

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-04 Thread Uwe Schindler
On my solaris box the fix does it. I tested it by hammering the same PHP script using get_browser() with and without patch. Without patch it gets this error. With not and script works :) The big problem with this bug is that when the error happens the first time (3 threads using get_browser()),

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Jay Smith
Uwe Schindler wrote: > One solution (attached is the patch, if nobody has someone against it I > will apply it): > I switch off the recursion protection for the browscap hash in > zend_hash_init_ex because this hash has no recursive things in it and is > not modified after it is created. > > Uwe

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Uwe Schindler
One solution (attached is the patch, if nobody has someone against it I will apply it): I switch off the recursion protection for the browscap hash in zend_hash_init_ex because this hash has no recursive things in it and is not modified after it is created. Uwe At 18:06 03.12.2003, Uwe Schindl

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Moriyoshi Koizumi
On 2003/12/04, at 2:06, Uwe Schindler wrote: This evening I will try to put a mutex at the beginning of get_browser to prevent more threads running at the same time there. But as I see this, this zend_hash_apply function is used very often could there be other effects if a global variable is a

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Wez Furlong
AIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, December 03, 2003 5:06 PM Subject: [PHP-DEV] browscap and nesting level too deep (bug #25916) > Today I got the error from bug #25916 several times on our webserver. > Looking through the code I found

Re: [PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Marcus Boerger
Hello Uwe, Wednesday, December 3, 2003, 6:06:13 PM, you wrote: > Today I got the error from bug #25916 several times on our webserver. > Looking through the code I found out the following: > * It depends NOT on the fact if there is a parameter to get_browser() or not > * It happens sometimes whe

[PHP-DEV] browscap and nesting level too deep (bug #25916)

2003-12-03 Thread Uwe Schindler
Today I got the error from bug #25916 several times on our webserver. Looking through the code I found out the following: * It depends NOT on the fact if there is a parameter to get_browser() or not * It happens sometimes when server is very heavy loaded, the homepage of the domain uses the get_b