Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Derick Rethans
On Tue, 7 Oct 2003, Rasmus Lerdorf wrote: > On Tue, 7 Oct 2003, Jani Taskinen wrote: > > Don't forget register_argv_argc php.ini directive. :) > > Right, that is what this patch fixed basically. register_argv_argc didn't > works if variables_order didn't include "S" which to me makes no sen

Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Rasmus Lerdorf
On Tue, 7 Oct 2003, Zeev Suraski wrote: > At 05:18 07/10/2003, Rasmus Lerdorf wrote: > >My big problem with this approach is that when variables_order does not > >include "S" then it seems inconsistent to have a partially populated > >$_SERVER array. If $_SERVER['argc'] is there, why aren't other

Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Rasmus Lerdorf
On Tue, 7 Oct 2003, Jani Taskinen wrote: > Don't forget register_argv_argc php.ini directive. :) Right, that is what this patch fixed basically. register_argv_argc didn't works if variables_order didn't include "S" which to me makes no sense. -Rasmus -- PHP Internals - PHP Runtime Develop

Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Zeev Suraski
At 05:18 07/10/2003, Rasmus Lerdorf wrote: On Mon, 6 Oct 2003, Greg MacLellan wrote: > That was my argument. I was saying that instead of ALWAYS creating $argv and > $argc, regardless of register_global status, it should ALWAYS create > $_SERVER['argv'] and $_SERVER['argc'], regardless of variable

Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Stanislav Malyshev
RL>> Andrei and I discussed this change and at the conceptual level at least RL>> $_SERVER should be populated with argc and argv if variables_order RL>> includes "S". If you have specifically configured your system to not RL>> create $_SERVER, then of course it shouldn't be there. The change

Re: [PHP-DEV] argv and argc on cliphp

2003-10-07 Thread Jani Taskinen
Don't forget register_argv_argc php.ini directive. :) --Jani On Mon, 6 Oct 2003, Rasmus Lerdorf wrote: >On Mon, 6 Oct 2003, Greg MacLellan wrote: >> > > That was my argument. I was saying that instead of ALWAYS creating $argv >> and >> > > $argc, regardless of register_global s

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Rasmus Lerdorf
On Mon, 6 Oct 2003, Greg MacLellan wrote: > > > That was my argument. I was saying that instead of ALWAYS creating $argv > and > > > $argc, regardless of register_global status, it should ALWAYS create > > > $_SERVER['argv'] and $_SERVER['argc'], regardless of variables_order > > > setting. > > > >

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Greg MacLellan
> > That was my argument. I was saying that instead of ALWAYS creating $argv and > > $argc, regardless of register_global status, it should ALWAYS create > > $_SERVER['argv'] and $_SERVER['argc'], regardless of variables_order > > setting. > > My big problem with this approach is that when variable

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Rasmus Lerdorf
On Mon, 6 Oct 2003, Greg MacLellan wrote: > That was my argument. I was saying that instead of ALWAYS creating $argv and > $argc, regardless of register_global status, it should ALWAYS create > $_SERVER['argv'] and $_SERVER['argc'], regardless of variables_order > setting. > > This has the double-

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Greg MacLellan
> > > You're not breaking code (since it can always use $_SERVER) and you're > > > not introducing any globals (which goes along with the register_globals > > > setting). > > > >Sure you are, you are creating the global $_SERVER which was specifically > >not enabled in your scenario. > > I may be m

Re: [PHP-DEV] argv and argc on cliphp

2003-10-05 Thread Zeev Suraski
> I don't really like the idea of populating two global variables, and I'm > not sure where this is at right now, since I've only been following > internals for the last few weeks. It's a good idea to be sure that argv > and argc are always available (though, arguably, argc is not all that > usefu

Re: [PHP-DEV] argv and argc on cliphp

2003-10-03 Thread Rasmus Lerdorf
On Fri, 3 Oct 2003, Greg MacLellan wrote: > Rasmus Lerdorf wrote: > > Andrei and I discussed this change and at the conceptual level at least > > $_SERVER should be populated with argc and argv if variables_order > > includes "S". If you have specifically configured your system to not > > crea

Re: [PHP-DEV] argv and argc on cliphp

2003-10-03 Thread Greg MacLellan
Rasmus Lerdorf wrote: Andrei and I discussed this change and at the conceptual level at least $_SERVER should be populated with argc and argv if variables_order includes "S". If you have specifically configured your system to not create $_SERVER, then of course it shouldn't be there. The chang

Re: [PHP-DEV] argv and argc on cliphp

2003-10-02 Thread Rasmus Lerdorf
Andrei and I discussed this change and at the conceptual level at least $_SERVER should be populated with argc and argv if variables_order includes "S". If you have specifically configured your system to not create $_SERVER, then of course it shouldn't be there. The change was to always make

Re: [PHP-DEV] argv and argc on cliphp

2003-10-02 Thread Alan Knowles
Stanislav - looks like andrei changed it - you better cc his private mail as I dont think he reads internals often. Regards Alan Stanislav Malyshev wrote: Is there any reason that PHP5 CLI does not register argc and argv in _SERVER like PHP4 does? There are a number of scripts that depend on it

[PHP-DEV] argv and argc on cliphp

2003-10-02 Thread Stanislav Malyshev
Is there any reason that PHP5 CLI does not register argc and argv in _SERVER like PHP4 does? There are a number of scripts that depend on it and just adding one more unnecessary incompatibility between PHP4 and PHP5. What is the problem with argv/argc being in _SERVER? -- Stanislav Malyshev, Z