Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-10 Thread Steph Fox
Folks, I'd say throw the warning if the switch is on and someone does call-time-pass-by-reference and turn that switch off by default. That's exactly the situation we have now - a warning when the INI setting is changed, for code that by default runs silently. And we offer a recommendation

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-09 Thread Steph Fox
Hannes, I'd say throw the warning if the switch is on and someone does call-time-pass-by-reference and turn that switch off by default. That's exactly the situation we have now - a warning when the INI setting is changed, for code that by default runs silently. And we offer a recommendation

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-09 Thread Hector Santos
Steph Fox wrote: The more I look into this, the weirder it seems. > [snip] > There's nothing wrong with it? So why throw an error at all? I have to say, I'm really confused over this. Either it's wrong, so you deliver a warning, or it's OK, so you don't. But what *really* bothers me is th

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Steph Fox
Hi Hector, As a new PHP extension author, it was one the first things I had to make sure was enabled to avoid the warning. May I suggest to make it [Extension] INI ready? I explored this and it seem to work, but not sure if its really the case. It appears that adding it in my PHP.INI [ex

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Hector Santos
Steph Fox wrote: Hi all, Does anyone have a good reason for keeping it switched on by default in PHP 5.3? Like, would switching it off by default break a lot of existing code, given that most users are a bit beyond PHP 3 now? As a new PHP extension author, it was one the first things I had

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Todd Ruth
On Thu, 2008-05-08 at 22:58 +0200, Hannes Magnusson wrote: > On Thu, May 8, 2008 at 10:08 PM, Todd Ruth <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-05-08 at 20:28 +0100, Steph Fox wrote: > >> ... > >> Does anyone have a good reason for keeping it switched on by default in PHP > >> 5.3? Like, would

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Hannes Magnusson
On Thu, May 8, 2008 at 9:28 PM, Steph Fox <[EMAIL PROTECTED]> wrote: > Does anyone have a good reason for keeping it switched on by default in PHP > 5.3? Like, would switching it off by default break a lot of existing code, > given that most users are a bit beyond PHP 3 now? I've never understood

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Hannes Magnusson
On Thu, May 8, 2008 at 10:08 PM, Todd Ruth <[EMAIL PROTECTED]> wrote: > On Thu, 2008-05-08 at 20:28 +0100, Steph Fox wrote: >> ... >> Does anyone have a good reason for keeping it switched on by default in PHP >> 5.3? Like, would switching it off by default break a lot of existing code, >> given th

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Steph Fox
Hi Stas, I think we also had a proposal back then to have func_gets_arg[s] ability to accept params by reference, and it should help with some scenarios. Sorry, I failed to parse that. What would help with some scenarios? - Steph -- PHP Internals - PHP Runtime Development Mailing List To u

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Steph Fox
Hi Todd, Well, I can at least comment on how it is used in the code that I inherited. Thanks for that. Just to be very clear, I'm not talking about removing it (even though it's been marked deprecated for 8 years plus). I'm just talking about switching it off by default. It's been turned of

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Stanislav Malyshev
Hi! I think we also had a proposal back then to have func_gets_arg[s] ability to accept params by reference, and it should help with some scenarios. -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL PROTECTED] -- PHP Internals

Re: [PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Todd Ruth
On Thu, 2008-05-08 at 20:28 +0100, Steph Fox wrote: > ... > Does anyone have a good reason for keeping it switched on by default in PHP > 5.3? Like, would switching it off by default break a lot of existing code, > given that most users are a bit beyond PHP 3 now? Well, I can at least comment on

[PHP-DEV] allow_call_time_pass_reference

2008-05-08 Thread Steph Fox
Hi all, Following a long and fairly embarrassing exchange of views with one of my php|architect authors, I finally discovered that allow_call_time_pass_reference is still on by default in PHP_5_3 (d'oh). This makes no sense to me because: - it throws an E_DEPRECATED warning, which nobody wil

Re: [PHP-DEV] allow_call_time_pass_reference

2003-11-20 Thread Andi Gutmans
I think it should stay the way it is (except for the bug). It should print a warning when people use it and the default allow_call_time_pass_reference directive is off. Andi At 07:52 AM 11/20/2003 +0100, Sebastian Bergmann wrote: I am wondering what should happen to the allow_call_time_p

[PHP-DEV] allow_call_time_pass_reference

2003-11-19 Thread Sebastian Bergmann
I am wondering what should happen to the allow_call_time_pass_reference php.ini directive. The following code, for instance, prints no warning with PHP 5 but with PHP 4. bar(&$b); ?> I think the allow_call_time_pass_reference directive should be removed as it is no longer