Re: [PHP-DEV] adding class entry getter for JsonSerializeable

2013-09-13 Thread chobie
2013/9/8 Johannes Schlüter > that only affects code in the same linker run (executable binary or .so) > as weak the linker to hide symbols. For stuff that should work in other > extensions one has to mark them as ZEND_API in the engine or PHPAPI in > core stuff, or a custom EXTENSIONNAME_API (see

Re: [PHP-DEV] adding class entry getter for JsonSerializeable

2013-09-07 Thread Johannes Schlüter
On Sat, 2013-09-07 at 17:46 +0200, Nikita Popov wrote: > The code has an "extern zend_class_entry *php_json_serializable_ce;" right > above that line. Shouldn't that be enough? that only affects code in the same linker run (executable binary or .so) as weak the linker to hide symbols. For stuff th

Re: [PHP-DEV] adding class entry getter for JsonSerializeable

2013-09-07 Thread chobie
Yea, but my php binary doesn't export php_json_serializable_ce. Did I missed something? nm /Users/chobie/.phpenv/versions/5.5-zts-debug/bin/php | grep php_json_serializable_ce 000100c00460 s _php_json_serializable_ce 2013/9/8 Nikita Popov > On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote: >

Re: [PHP-DEV] adding class entry getter for JsonSerializeable

2013-09-07 Thread Nikita Popov
On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote: > Hi internals, > > I realized we could not retrieve php_json_serializable_ce from other > extension module. JsonSerializeable interface is easy to serialize with > `json_encode`. So I want to adding getter function. > > The patch can be found here:

[PHP-DEV] adding class entry getter for JsonSerializeable

2013-09-07 Thread chobie
Hi internals, I realized we could not retrieve php_json_serializable_ce from other extension module. JsonSerializeable interface is easy to serialize with `json_encode`. So I want to adding getter function. The patch can be found here: https://github.com/chobie/php-src/compare/adding-jsonseriali