Re: [PHP-DEV] writing .phpt tests against IS_INDIRECT values

2016-04-20 Thread Nikita Popov
On Wed, Apr 20, 2016 at 5:08 PM, Adam Baratz wrote: > I'm contributing to an extension -- > https://github.com/jbboehr/php-mustache > -- and part of that has been little fixes for PHP7. I posted a PR to fix > how it was handling zvals that came in as IS_INDIRECT. The maintainer asked > if I could

[PHP-DEV] writing .phpt tests against IS_INDIRECT values

2016-04-20 Thread Adam Baratz
I'm contributing to an extension -- https://github.com/jbboehr/php-mustache -- and part of that has been little fixes for PHP7. I posted a PR to fix how it was handling zvals that came in as IS_INDIRECT. The maintainer asked if I could extend the .phpt coverage accordingly. The reading I've done ha

Re: [PHP-DEV] Writing PHPT tests

2008-02-03 Thread zoe
Please do :-) I admit I have been meaning to do this for ages and it's bad that I haven't got around to it. Rob Nicholson From: zoe <[EMAIL PROTECTED]> To: internals@lists.php.net Date: 02/02/2008 11:21 Subject: [P

Re: [PHP-DEV] Writing PHPT tests

2008-02-03 Thread zoe
Jani Taskinen wrote: You simply ignored my email or never got it? The correct place for such scripts is not in the "root" but in scripts/dev/ --Jani Jani - of course I wouldn't ignore a mail from you :-) - I didn't see it. I talked a bit to Johannes on IRC about where to put it and in the en

Re: [PHP-DEV] Writing PHPT tests

2008-02-02 Thread Jani Taskinen
You simply ignored my email or never got it? The correct place for such scripts is not in the "root" but in scripts/dev/ --Jani zoe kirjoitti: Hi - for any of you that are writing PHPT tests for existing extensions - I put a PHP script called generate_phpt.php into PHP 5.3 yesterday which mi

Re: [PHP-DEV] Writing PHPT tests

2008-02-02 Thread Rob Nicholson
s too. Since the testcase generator adds these comments its worth documenting them. I'll produce a patch to the documentation for review if you like. Rob Nicholson From: zoe <[EMAIL PROTECTED]> To: internals@lists.php.net Date: 02/02/2008 11:21 Subject: [PHP-DEV] Writing PHPT t

[PHP-DEV] Writing PHPT tests

2008-02-02 Thread zoe
Hi - for any of you that are writing PHPT tests for existing extensions - I put a PHP script called generate_phpt.php into PHP 5.3 yesterday which might help a little. It's quite a simple command line script (Raghu and I wrote it last year), it works by looking at the {{{proto line for a funct