Re: [PHP-DEV] Valgrind failures

2017-06-22 Thread Nikita Popov
On Thu, Jun 22, 2017 at 9:12 PM, Jakub Zelenka wrote: > Ah thanks I see! Just out of interest what changes actually caused it as > it's master only? > It's due to https://github.com/php/php-src/commit/141d1ba9801f742dc5d9ccd06e02b94284c4deb7, which has only been introduced in master. Nikita >

Re: [PHP-DEV] Valgrind failures

2017-06-22 Thread Jakub Zelenka
Ah thanks I see! Just out of interest what changes actually caused it as it's master only? On Thu, Jun 22, 2017 at 7:51 PM, Nikita Popov wrote: > On Thu, Jun 22, 2017 at 8:45 PM, Jakub Zelenka wrote: > >> Hi Dmitry, >> >> I noticed that valgind reports a lot of memleaks for the master and it >>

Re: [PHP-DEV] Valgrind failures

2017-06-22 Thread Nikita Popov
On Thu, Jun 22, 2017 at 8:45 PM, Jakub Zelenka wrote: > Hi Dmitry, > > I noticed that valgind reports a lot of memleaks for the master and it > seems to be related to the freeing of registered classes on shutdown when > running cli. I'm wondering if it can be related to your recent changes that >

[PHP-DEV] Valgrind failures

2017-06-22 Thread Jakub Zelenka
Hi Dmitry, I noticed that valgind reports a lot of memleaks for the master and it seems to be related to the freeing of registered classes on shutdown when running cli. I'm wondering if it can be related to your recent changes that were touching that parts. I haven't found the commit that caused b