Re: [PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex()

2007-04-04 Thread Antony Dovgal
On 04/04/2007 03:18 AM, js wrote: Hi Antony. Thanks you for replying. > If so, any reason to break the coding standard in this instance? Standards are general rules, there might be some exceptions. (It doesn't mean I personally like this code or encourage to ignore the standards). > and wha

Re: [PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex()

2007-04-03 Thread js
Hi Antony. Thanks you for replying. > If so, any reason to break the coding standard in this instance? Standards are general rules, there might be some exceptions. (It doesn't mean I personally like this code or encourage to ignore the standards). > and what does, in this context, 'duplicat

Re: [PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex()

2007-04-03 Thread Antony Dovgal
On 04/03/2007 07:26 PM, js wrote: Hi gurus. Fiddling with PHP extensions I found the following code in 'sapi_add_header_ex()' in SAPI.c if (!duplicate) efree(header_line); which makes me wonder because the other day I read CODING_STANDARD included in PHP src which says "[1] Function

[PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex()

2007-04-03 Thread js
Hi gurus. Fiddling with PHP extensions I found the following code in 'sapi_add_header_ex()' in SAPI.c if (!duplicate) efree(header_line); which makes me wonder because the other day I read CODING_STANDARD included in PHP src which says "[1] Functions that are given pointers to resource