On 26.11.2016 at 13:55, Christoph M. Becker wrote:
> On 26.11.2016 at 12:45, Nikita Popov wrote:
>
>> The fact that php_pcre.c uses zval_dtor() is simply a bug, because code like
>>
>> $obj = new stdClass;
>> $obj->obj = $obj;
>> preg_match('/./', 'x', $obj);
>>
>> leaks.
>
> Indeed.
On 26.11.2016 at 12:45, Nikita Popov wrote:
> On Sat, Nov 26, 2016 at 12:29 PM, Christoph M. Becker
> wrote:
>
>> On 26.11.2016 at 01:47, Thomas Hruska wrote:
>>
>>> Okay, everyone has been helpful. Thanks. I'll go with:
>>>
>>>
>>> zval *zprevcount = NULL;
>>> zend_long count;
>>>
>>>
On Sat, Nov 26, 2016 at 12:29 PM, Christoph M. Becker
wrote:
> On 26.11.2016 at 01:47, Thomas Hruska wrote:
>
> > Okay, everyone has been helpful. Thanks. I'll go with:
> >
> >
> > zval *zprevcount = NULL;
> > zend_long count;
> >
> > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS
On 26.11.2016 at 01:47, Thomas Hruska wrote:
> Okay, everyone has been helpful. Thanks. I'll go with:
>
>
> zval *zprevcount = NULL;
> zend_long count;
>
> if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|z/",
> &zprevcount) == FAILURE) return;
>
> ...
>
> if (zpr
