Re: [PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread tyson andre
Hi Côme Chilliet, > So in the example of ldap_bind: >     if (zend_parse_parameters(ZEND_NUM_ARGS(), "r|ss", &link, &ldap_bind_dn, &ldap_bind_dnlen, &ldap_bind_pw, &ldap_bind_pwlen) != SUCCESS) > { RETURN_THROWS(); } > > With ldap_bind($link, NULL), ldap_bind_dn is not NULL but an empty strin

Re: [PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread G. P. B.
On Thu, 17 Sep 2020 at 15:18, Côme Chilliet < come.chill...@fusiondirectory.org> wrote: > Le Thu, 17 Sep 2020 15:03:05 +0200, > "G. P. B." a écrit : > > A lot of the documentation is not up to date and will needs to be updated > > after > > there has been a check of the argument names for consis

Re: [PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread Côme Chilliet
Le Thu, 17 Sep 2020 15:03:05 +0200, "G. P. B." a écrit : > A lot of the documentation is not up to date and will needs to be updated > after > there has been a check of the argument names for consistency with other > extensions in regards to named params, the stubs are the source of trust. I th

Re: [PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread tyson andre
Hi Côme Chilliet and G. P. B., > Hello, > > After playing with phpstan and seeing their stubs for some LDAP functions > were >  wrong, I noticed that documentation for LDAP functions and stubs in >  ext/ldap/ldap.stub.php differs. Also see discussion in https://github.com/phan/phan/issues/4194 h

Re: [PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread G. P. B.
On Thu, 17 Sep 2020 at 14:53, Côme Chilliet < come.chill...@fusiondirectory.org> wrote: > Hello, > > After playing with phpstan and seeing their stubs for some LDAP functions > were > wrong, I noticed that documentation for LDAP functions and stubs in > ext/ldap/ldap.stub.php differs. > A lot o

[PHP-DEV] Stubs in ext/ldap

2020-09-17 Thread Côme Chilliet
Hello, After playing with phpstan and seeing their stubs for some LDAP functions were wrong, I noticed that documentation for LDAP functions and stubs in ext/ldap/ldap.stub.php differs. Especially in a lot of functions, the documentation states "string $dn = NULL" but the stub states non-nulla