Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Richard Quadling
On 18 November 2011 17:37, Ferenc Kovacs wrote: > > > On Fri, Nov 18, 2011 at 5:40 PM, Richard Quadling > wrote: >> >> On 18 November 2011 13:31, Felipe Pena wrote: >> > 2011/11/18 Pierre Joye : >> >> same here, and for any other places in the ob_* APIs. Functions >> >> returns false on error, c

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Ferenc Kovacs
On Fri, Nov 18, 2011 at 5:40 PM, Richard Quadling wrote: > On 18 November 2011 13:31, Felipe Pena wrote: > > 2011/11/18 Pierre Joye : > >> same here, and for any other places in the ob_* APIs. Functions > >> returns false on error, cleaning something already cleaned or empty is > >> not an erro.

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Richard Quadling
On 18 November 2011 13:31, Felipe Pena wrote: > 2011/11/18 Pierre Joye : >> same here, and for any other places in the ob_* APIs. Functions >> returns false on error, cleaning something already cleaned or empty is >> not an erro. >> > > Same opinion here. WOW. All the developers agreeing with a c

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Felipe Pena
2011/11/18 Pierre Joye : > same here, and for any other places in the ob_* APIs. Functions > returns false on error, cleaning something already cleaned or empty is > not an erro. > Same opinion here. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Pierre Joye
same here, and for any other places in the ob_* APIs. Functions returns false on error, cleaning something already cleaned or empty is not an erro. On Fri, Nov 18, 2011 at 2:08 PM, Ilia Alshanetsky wrote: > I agree with Stas' point there is really no need to force people do > the while (ob_get_le

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread David Zülke
So the consensus so far is to drop notices from ob_clean(), ob_end_clean() and ob_get_clean()? What about ob_flush() or others? David On 18.11.2011, at 14:08, Ilia Alshanetsky wrote: > I agree with Stas' point there is really no need to force people do > the while (ob_get_level()) ob_end_cle

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Ilia Alshanetsky
I agree with Stas' point there is really no need to force people do the while (ob_get_level()) ob_end_clean(); loop or "force" people to use the @ob_end_clean(); to avoid notices. If there are no buffers to clear it should be a noop, without any notices being raised. On Fri, Nov 18, 2011 at 12:04

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Stas Malyshev
Hi! First of all, ob_clean() and ob_end_clean() will raise the same notice even in PHP 5.3. It seems inconsistent to me to treat these three differently, so in that regard, PHP 5.4 is actually fixing behavior (although arguably the other way to approach the problem is to remove the notice from a

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread David Zülke
On 17.11.2011, at 21:46, Matthew Weier O'Phinney wrote: > * ob_get_clean() now raises a notice if no buffer to delete > Prior to 5.4.0RC1, if there were no buffers left to delete, > ob_get_clean() was silent. It now raises a notice -- which, when > using PHPUnit, means an error is now raised

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Patrick ALLAERT
2011/11/17 Rasmus Lerdorf : > On 11/17/2011 03:10 PM, Stas Malyshev wrote: >> Hi! >> >>>     I recall from earlier discussions that Stas was in favor of reverting >>>     this change -- what's the status at this time? This single change >> >> I was not and still am not - I think if something warran

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Rasmus Lerdorf
On 11/17/2011 03:10 PM, Stas Malyshev wrote: > Hi! > >> I recall from earlier discussions that Stas was in favor of reverting >> this change -- what's the status at this time? This single change > > I was not and still am not - I think if something warrants notice this > is exactly the ca

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Matthew Weier O'Phinney
On 2011-11-17, Stas Malyshev wrote: > > I recall from earlier discussions that Stas was in favor of > > reverting this change -- what's the status at this time? This > > single change > > I was not and still am not - I think if something warrants notice this > is exactly the case. Con

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Ferenc Kovacs
Hi Matthew, my replies are inline On Thu, Nov 17, 2011 at 9:46 PM, Matthew Weier O'Phinney < weierophin...@php.net> wrote: > Greetings! > > My team and I (which means Ralph Schindler and Enrico Zimuel) took some > time this week to: > > * Build PHP 5.4.0RC1 and run make tests (and send feedback)

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Stas Malyshev
Hi! I recall from earlier discussions that Stas was in favor of reverting this change -- what's the status at this time? This single change I was not and still am not - I think if something warrants notice this is exactly the case. Conversion of array to string "Array" IMHO makes no

[PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-17 Thread Matthew Weier O'Phinney
Greetings! My team and I (which means Ralph Schindler and Enrico Zimuel) took some time this week to: * Build PHP 5.4.0RC1 and run make tests (and send feedback) * Run Zend Framework 1.11 unit tests against PHP 5.4.0RC1 * Run Zend Framework 2.0 (dev) unit tests against PHP 5.4.0RC1 We found t