Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Yasuo Ohgaki
Hi all, On Sat, Aug 10, 2013 at 6:50 PM, Yasuo Ohgaki wrote: > Anyone has good name for the option? I'll create a API that touches session data. If API is not implemented by save handler, then it works as it is now. Therefore, no ini setting is needed. My apology for the noise. -- Yasuo Ohg

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Yasuo Ohgaki
Hi Leigh, On Sat, Aug 10, 2013 at 7:02 PM, Leigh wrote: > I think custom handlers should still function as they always did, you > should not track whether the session changed or not for them, they can > easily track that themselves. > > For the built-in file based handler, do you think it would

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Leigh
On 10 August 2013 10:54, Yasuo Ohgaki wrote: > Hi Leigh, > > On Sat, Aug 10, 2013 at 6:48 PM, Leigh wrote: > >> What is the performance difference if you just touch the files instead >> of writing them? (i.e. update mtime) > > > It will be faster for sure for files and database/network > based

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Yasuo Ohgaki
Hi Leigh, On Sat, Aug 10, 2013 at 6:48 PM, Leigh wrote: > What is the performance difference if you just touch the files instead of > writing them? (i.e. update mtime) It will be faster for sure for files and database/network based session storage, but I didn't took benchmark. I can make def

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Yasuo Ohgaki
Hi all, On Sat, Aug 10, 2013 at 6:45 PM, Yasuo Ohgaki wrote: > On Sat, Aug 10, 2013 at 6:26 PM, Leigh wrote: > >> How does this affect GC of sessions? If a session is not written for 30 >> minutes, but the user is active, is there a potential for their session to >> be GC and destroyed? > > > T

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Leigh
On 10 August 2013 10:45, Yasuo Ohgaki wrote: > Hi Leigh, > > On Sat, Aug 10, 2013 at 6:26 PM, Leigh wrote: > >> How does this affect GC of sessions? If a session is not written for 30 >> minutes, but the user is active, is there a potential for their session to >> be GC and destroyed? > > > Than

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Yasuo Ohgaki
Hi Leigh, On Sat, Aug 10, 2013 at 6:26 PM, Leigh wrote: > How does this affect GC of sessions? If a session is not written for 30 > minutes, but the user is active, is there a potential for their session to > be GC and destroyed? Thank you for heads up. I'll make it optional and document the s

Re: [PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-10 Thread Leigh
On 10 August 2013 04:45, Yasuo Ohgaki wrote: > > This patch removes unneeded session writes. i.e. session data > has not changed, just skip write and improve performance. > > Although it is safe to remove unneeded writes, if many of us > want ini setting for enable/disable write short cut, I'll

[PHP-DEV] Request #17860 Suggestion: auto detect whether session changed

2013-08-09 Thread Yasuo Ohgaki
Hi all, Following patch against master https://gist.github.com/yohgaki/6198611 implements FR #17860 https://bugs.php.net/bug.php?id=17860 This patch removes unneeded session writes. i.e. session data has not changed, just skip write and improve performance. Although it is safe to remove unnee